You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/11/09 19:14:53 UTC
[I] [C++] Use the random array generators from testing/random.h in the concatenation tests [arrow]
felipecrv opened a new issue, #38656:
URL: https://github.com/apache/arrow/issues/38656
### Describe the enhancement requested
Leverage the random generators that explore more of the state space arrays can be in to test concatenation instead of having simpler generators in `concatenate_test.cc` itself.
The concatenation tests in the Go implementation share random array generation with many other tests and I think the C++ implementation would benefit from doing the same.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Use the random array generators from testing/random.h in the concatenation tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #38656: [C++] Use the random array generators from testing/random.h in the concatenation tests
URL: https://github.com/apache/arrow/issues/38656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Use the random array generators from testing/random.h in the concatenation tests [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #38656:
URL: https://github.com/apache/arrow/issues/38656#issuecomment-1806507591
A related issue: there are two algorithms for generating random list and list-like arrays in `testing/random.cc`. The two algorithms take different parameters and have different uses, but it should be possible to write a very general implementation that can accept the two parameterizations.
Context: https://github.com/apache/arrow/pull/35345/files/1cdefacff508dc48f7ded6e45cc8169d007cb29c#r1388254192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Use the random array generators from testing/random.h in the concatenation tests [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #38656:
URL: https://github.com/apache/arrow/issues/38656#issuecomment-1804461595
FYI @bkietz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Use the random array generators from testing/random.h in the concatenation tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #38656:
URL: https://github.com/apache/arrow/issues/38656#issuecomment-4359096269
This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 14 days. If this improvement is still desired but has no current owner, please add the 'Status: needs champion' label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org