You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/22 09:41:38 UTC

[GitHub] [incubator-tvm] intheworld opened a new pull request #6527: [FIX] fix the python script for building resnet (#6526)

intheworld opened a new pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527


   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6527: [FIX] fix the python script for building resnet (#6526)

Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527#discussion_r493185840



##########
File path: rust/tvm/examples/resnet/build.rs
##########
@@ -23,6 +23,7 @@ use std::{path::Path, process::Command};
 fn main() -> Result<()> {
     let output = Command::new("python3")
         .arg(concat!(env!("CARGO_MANIFEST_DIR"), "/src/build_resnet.py"))
+        //.arg(&format!("--pretrained"))

Review comment:
       Thanks @intheworld, I also agree that we should keep the pretrained flag as it is

##########
File path: rust/tvm/examples/resnet/build.rs
##########
@@ -23,6 +23,7 @@ use std::{path::Path, process::Command};
 fn main() -> Result<()> {
     let output = Command::new("python3")
         .arg(concat!(env!("CARGO_MANIFEST_DIR"), "/src/build_resnet.py"))
+        //.arg(&format!("--pretrained"))

Review comment:
       Thanks @intheworld, I also agree that we should keep the pretrained flag as it is instead of comment it out




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] intheworld commented on pull request #6527: [FIX] fix the python script for building resnet (#6526)

Posted by GitBox <gi...@apache.org>.
intheworld commented on pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527#issuecomment-696629218


   @jroesch @ehsanmok please review this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] intheworld commented on a change in pull request #6527: [FIX] fix the python script for building resnet (#6526)

Posted by GitBox <gi...@apache.org>.
intheworld commented on a change in pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527#discussion_r493224684



##########
File path: rust/tvm/examples/resnet/build.rs
##########
@@ -23,6 +23,7 @@ use std::{path::Path, process::Command};
 fn main() -> Result<()> {
     let output = Command::new("python3")
         .arg(concat!(env!("CARGO_MANIFEST_DIR"), "/src/build_resnet.py"))
+        //.arg(&format!("--pretrained"))

Review comment:
       Ok, I will remove this line. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] intheworld commented on a change in pull request #6527: [FIX] fix the python script for building resnet (#6526)

Posted by GitBox <gi...@apache.org>.
intheworld commented on a change in pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527#discussion_r493163292



##########
File path: rust/tvm/examples/resnet/build.rs
##########
@@ -23,6 +23,7 @@ use std::{path::Path, process::Command};
 fn main() -> Result<()> {
     let output = Command::new("python3")
         .arg(concat!(env!("CARGO_MANIFEST_DIR"), "/src/build_resnet.py"))
+        //.arg(&format!("--pretrained"))

Review comment:
       No, I intent to add this. Someone who wants to use a pre-trained model could just uncomment this line. I think this is more convenient.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6527: [FIX] fix the python script for building resnet (#6526)

Posted by GitBox <gi...@apache.org>.
mbaret commented on a change in pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527#discussion_r492747948



##########
File path: rust/tvm/examples/resnet/build.rs
##########
@@ -23,6 +23,7 @@ use std::{path::Path, process::Command};
 fn main() -> Result<()> {
     let output = Command::new("python3")
         .arg(concat!(env!("CARGO_MANIFEST_DIR"), "/src/build_resnet.py"))
+        //.arg(&format!("--pretrained"))

Review comment:
       Left in by accident?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6527: [FIX] fix the python script for building resnet (#6526)

Posted by GitBox <gi...@apache.org>.
mbaret commented on a change in pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527#discussion_r492747948



##########
File path: rust/tvm/examples/resnet/build.rs
##########
@@ -23,6 +23,7 @@ use std::{path::Path, process::Command};
 fn main() -> Result<()> {
     let output = Command::new("python3")
         .arg(concat!(env!("CARGO_MANIFEST_DIR"), "/src/build_resnet.py"))
+        //.arg(&format!("--pretrained"))

Review comment:
       Left in by accident?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] intheworld commented on pull request #6527: [FIX] fix the python script for building resnet (#6526)

Posted by GitBox <gi...@apache.org>.
intheworld commented on pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527#issuecomment-696629218


   @jroesch @ehsanmok please review this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #6527: [FIX] fix the python script for building resnet (#6526)

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] intheworld commented on a change in pull request #6527: [FIX] fix the python script for building resnet (#6526)

Posted by GitBox <gi...@apache.org>.
intheworld commented on a change in pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527#discussion_r493163292



##########
File path: rust/tvm/examples/resnet/build.rs
##########
@@ -23,6 +23,7 @@ use std::{path::Path, process::Command};
 fn main() -> Result<()> {
     let output = Command::new("python3")
         .arg(concat!(env!("CARGO_MANIFEST_DIR"), "/src/build_resnet.py"))
+        //.arg(&format!("--pretrained"))

Review comment:
       No, I intent to add this. Someone who wants to use a pre-trained model could just uncomment this line. I think this is more convenient.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org