[jira] [Created] (HADOOP-18633) fix test AbstractContractDistCpTest#testDistCpUpdateCheckFileSkip

["Mehakmeet Singh (Jira)" <ji...@apache.org>]

Mehakmeet Singh created HADOOP-18633:
----------------------------------------

             Summary: fix test AbstractContractDistCpTest#testDistCpUpdateCheckFileSkip 
                 Key: HADOOP-18633
                 URL: https://issues.apache.org/jira/browse/HADOOP-18633
             Project: Hadoop Common
          Issue Type: Bug
          Components: tools/distcp
            Reporter: Mehakmeet Singh
            Assignee: Mehakmeet Singh


In the newly introduced test testDistCpUpdateCheckFileSkip, for the first pass of "distcp -update", target file should not be present so that the copy takes place and creates the target file. 

Currently, we create both the source and target file with same block size from the start which can lead to flakiness due to race condition causing the modification time of the target file to be greater than/equal to the source and not copy the file at all. This can be seen more in the TestLocalContractDistCp due to no remote calls to create the target.
{code:java}
java.lang.AssertionError: Mismatch in COPY counter value expected:<1> but was:<0>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.apache.hadoop.tools.contract.AbstractContractDistCpTest.verifySkipAndCopyCounter(AbstractContractDistCpTest.java:1000)
	at org.apache.hadoop.tools.contract.AbstractContractDistCpTest.testDistCpUpdateCheckFileSkip(AbstractContractDistCpTest.java:919) {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org