[GitHub] [trafficserver] maskit commented on a change in pull request #7499: Move has_request_body to ProxyTransaction

[GitBox <gi...@apache.org>]

maskit commented on a change in pull request #7499:
URL: https://github.com/apache/trafficserver/pull/7499#discussion_r572635330



##########
File path: proxy/http/HttpSM.cc
##########
@@ -2073,7 +2073,9 @@ HttpSM::state_send_server_request_header(int event, void *data)
     free_MIOBuffer(server_entry->write_buffer);
     server_entry->write_buffer = nullptr;
     method                     = t_state.hdr_info.server_request.method_get_wksidx();
-    if (!t_state.api_server_request_body_set && method != HTTP_WKSIDX_TRACE && HttpTransact::has_request_body(&t_state, ua_txn)) {
+    if (!t_state.api_server_request_body_set && method != HTTP_WKSIDX_TRACE &&
+        ua_txn->has_request_body(t_state.hdr_info.request_content_length,

Review comment:
       Does ProxyTransaction need these two values to answer whether it has request body? I guess it already has enough info in it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org