You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/05 08:04:19 UTC

[GitHub] [cloudstack] DaanHoogland commented on pull request #6851: api,server: fix listing vm metrics for infra resources

DaanHoogland commented on PR #6851:
URL: https://github.com/apache/cloudstack/pull/6851#issuecomment-1336915131

   > I think we should keep the since @DaanHoogland as it's not a new API (may affect data in apidocs), for the Deprecated, can you check [16f2896](https://github.com/apache/cloudstack/commit/16f2896940cb6ae5557a51b6b439bd71917e1781) where this was introduced? I think too Deprecated should be removed.
   
   The since attribute is not incorporated with the ApiDocs, see for instance https://cloudstack.apache.org/api/apidocs-4.17/apis/addNetscalerLoadBalancer.html . it would only help in trouble shooting which is important enough. I think adding a anti-dated ssince attribute is misleading and implies something that is not true. I really think it should be removed on this class or set to 4.18/4.19


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org