You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by icexelloss <gi...@git.apache.org> on 2017/10/20 15:20:28 UTC
[GitHub] spark pull request #19544: [SPARK-22323] Design doc for pandas_udf
GitHub user icexelloss opened a pull request:
https://github.com/apache/spark/pull/19544
[SPARK-22323] Design doc for pandas_udf
I open this PR so we can have a place to discuss the design.
We don't necessary need to merge a md file for the doc - this be embeded python documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/icexelloss/spark pandas-udf-design-doc-SPARK-22323
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19544.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19544
----
commit 3005312e0b5c0255ddd23736bfd24e2abf6cad95
Author: Li Jin <ic...@gmail.com>
Date: 2017-10-20T15:09:08Z
Initial design doc for pandas_udf
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by icexelloss <gi...@git.apache.org>.
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19544
Sorry for the late reply.
@srowen At this point I would like to have feedback on the design doc so we can move forward with implementation or a formal Spark docs if people prefer. What do you think is a best way to discuss design document?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19544
I don't think we would merge this to Spark docs right? I don't think this is an efficient way to discuss a design document if that's the intent
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by icexelloss <gi...@git.apache.org>.
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19544
Close this in favor of the google doc.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19544
This is not ready yet. Eventually, we need a document for vectorized Python UDF
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19544
**[Test build #82935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82935/testReport)** for PR 19544 at commit [`3005312`](https://github.com/apache/spark/commit/3005312e0b5c0255ddd23736bfd24e2abf6cad95).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by icexelloss <gi...@git.apache.org>.
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19544
Do people prefer google doc? I can do that too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19544
**[Test build #82935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82935/testReport)** for PR 19544 at commit [`3005312`](https://github.com/apache/spark/commit/3005312e0b5c0255ddd23736bfd24e2abf6cad95).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19544: [SPARK-22323] Design doc for pandas_udf
Posted by icexelloss <gi...@git.apache.org>.
Github user icexelloss closed the pull request at:
https://github.com/apache/spark/pull/19544
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19544
@jiangxb1987 will reorg the existing Spark SQL doc. We can think about how to put this into the new version of Spark SQL doc.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by icexelloss <gi...@git.apache.org>.
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19544
Ok. I will put in a google doc and ping your guys. Thanks!
On Wed, Oct 25, 2017 at 11:25 AM Wenchen Fan <no...@github.com>
wrote:
> I feel google doc is easier to review and discuss
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/19544#issuecomment-339367854>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAwbrIqz5Uyp7DJXOI8Ofq_GyJTs1MEIks5sv1LugaJpZM4QA0na>
> .
>
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19544
I feel google doc is easier to review and discuss
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by icexelloss <gi...@git.apache.org>.
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19544
cc @cloud-fan @ueshin @HyukjinKwon @gatorsmile @viirya
To continue the discussion on #19505
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19544
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19544
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82935/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19544: [SPARK-22323] Design doc for pandas_udf
Posted by icexelloss <gi...@git.apache.org>.
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19544
Thanks all for the advice. I've put this in a google doc.
https://docs.google.com/document/d/1KlLaa-xJ3oz28xlEJqXyCAHU3dwFYkFs_ixcUXrJNTc/edit?usp=sharing
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org