You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/17 16:44:58 UTC
[GitHub] [superset] kgabryje opened a new pull request #18790: [WIP] chore(native-filters): Remove cascading popovers from filter bar
kgabryje opened a new pull request #18790:
URL: https://github.com/apache/superset/pull/18790
CC @michael-s-molina
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed pull request #18790: [WIP] chore(native-filters): Remove cascading popovers from filter bar
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #18790:
URL: https://github.com/apache/superset/pull/18790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #18790: [WIP] chore(native-filters): Remove cascading popovers from filter bar
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #18790:
URL: https://github.com/apache/superset/pull/18790#discussion_r810084565
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/state.ts
##########
@@ -20,30 +20,28 @@ import { useMemo } from 'react';
import { useSelector } from 'react-redux';
import {
DataMaskStateWithId,
+ ensureIsArray,
ExtraFormData,
- NativeFiltersState,
} from '@superset-ui/core';
import { mergeExtraFormData } from '../../utils';
// eslint-disable-next-line import/prefer-default-export
-export function useCascadingFilters(
+export function useFilterDependencies(
id: string,
dataMaskSelected?: DataMaskStateWithId,
): ExtraFormData {
- const { filters } = useSelector<any, NativeFiltersState>(
- state => state.nativeFilters,
+ const parentIds = useSelector<any, string[] | undefined>(
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #18790: [WIP] chore(native-filters): Remove cascading popovers from filter bar
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #18790:
URL: https://github.com/apache/superset/pull/18790#discussion_r810015355
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/state.ts
##########
@@ -20,30 +20,28 @@ import { useMemo } from 'react';
import { useSelector } from 'react-redux';
import {
DataMaskStateWithId,
+ ensureIsArray,
ExtraFormData,
- NativeFiltersState,
} from '@superset-ui/core';
import { mergeExtraFormData } from '../../utils';
// eslint-disable-next-line import/prefer-default-export
-export function useCascadingFilters(
+export function useFilterDependencies(
id: string,
dataMaskSelected?: DataMaskStateWithId,
): ExtraFormData {
- const { filters } = useSelector<any, NativeFiltersState>(
- state => state.nativeFilters,
+ const parentIds = useSelector<any, string[] | undefined>(
Review comment:
Change to `dependencies` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #18790: [WIP] chore(native-filters): Remove cascading popovers from filter bar
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #18790:
URL: https://github.com/apache/superset/pull/18790#discussion_r810015355
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/state.ts
##########
@@ -20,30 +20,28 @@ import { useMemo } from 'react';
import { useSelector } from 'react-redux';
import {
DataMaskStateWithId,
+ ensureIsArray,
ExtraFormData,
- NativeFiltersState,
} from '@superset-ui/core';
import { mergeExtraFormData } from '../../utils';
// eslint-disable-next-line import/prefer-default-export
-export function useCascadingFilters(
+export function useFilterDependencies(
id: string,
dataMaskSelected?: DataMaskStateWithId,
): ExtraFormData {
- const { filters } = useSelector<any, NativeFiltersState>(
- state => state.nativeFilters,
+ const parentIds = useSelector<any, string[] | undefined>(
Review comment:
Change to dependencies here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #18790: [WIP] chore(native-filters): Remove cascading popovers from filter bar
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #18790:
URL: https://github.com/apache/superset/pull/18790#discussion_r810015355
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/state.ts
##########
@@ -20,30 +20,28 @@ import { useMemo } from 'react';
import { useSelector } from 'react-redux';
import {
DataMaskStateWithId,
+ ensureIsArray,
ExtraFormData,
- NativeFiltersState,
} from '@superset-ui/core';
import { mergeExtraFormData } from '../../utils';
// eslint-disable-next-line import/prefer-default-export
-export function useCascadingFilters(
+export function useFilterDependencies(
id: string,
dataMaskSelected?: DataMaskStateWithId,
): ExtraFormData {
- const { filters } = useSelector<any, NativeFiltersState>(
- state => state.nativeFilters,
+ const parentIds = useSelector<any, string[] | undefined>(
Review comment:
Change to `savedDependencies` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #18790: [WIP] chore(native-filters): Remove cascading popovers from filter bar
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #18790:
URL: https://github.com/apache/superset/pull/18790#issuecomment-1044567319
@kgabryje Thanks for improving the types. I think this PR is ready to be merged with my PR so we can execute the tests. For historical reasons, can you add a description to this PR? I know it will be closed but I would like to reference it in my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org