You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2023/04/24 08:20:26 UTC

[GitHub] [flink] zentol opened a new pull request, #22474: [FLINK-31912][build] Upgrade bytebuddy to 1.14.4

zentol opened a new pull request, #22474:
URL: https://github.com/apache/flink/pull/22474

   For Java 17 compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #22474: [FLINK-31912][build] Upgrade bytebuddy to 1.14.4

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol merged PR #22474:
URL: https://github.com/apache/flink/pull/22474


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22474: [FLINK-31912][build] Upgrade bytebuddy to 1.14.4

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22474:
URL: https://github.com/apache/flink/pull/22474#issuecomment-1519620086

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0e46c7885870cfdb2da6a87597b341fc83de4a5c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0e46c7885870cfdb2da6a87597b341fc83de4a5c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0e46c7885870cfdb2da6a87597b341fc83de4a5c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #22474: [FLINK-31912][build] Upgrade bytebuddy to 1.14.4

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22474:
URL: https://github.com/apache/flink/pull/22474#discussion_r1175279358


##########
pom.xml:
##########
@@ -602,14 +602,21 @@ under the License.
 				<!-- mockito/powermock mismatch -->
 				<groupId>net.bytebuddy</groupId>
 				<artifactId>byte-buddy</artifactId>
-				<version>1.10.14</version>
+				<version>1.14.4</version>
 			</dependency>
 
 			<dependency>
 				<!-- mockito/powermock mismatch -->
 				<groupId>net.bytebuddy</groupId>
 				<artifactId>byte-buddy-agent</artifactId>
-				<version>1.10.14</version>
+				<version>1.14.4</version>
+			</dependency>
+
+			<!-- For dependency convergence -->
+			<dependency>
+				<groupId>net.java.dev.jna</groupId>
+				<artifactId>jna</artifactId>
+				<version>5.12.1</version>

Review Comment:
   The tests appear to be passing so far; maybe it just needs to be a newer version than what testcontainers expects?.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on a diff in pull request #22474: [FLINK-31912][build] Upgrade bytebuddy to 1.14.4

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #22474:
URL: https://github.com/apache/flink/pull/22474#discussion_r1175217524


##########
pom.xml:
##########
@@ -602,14 +602,21 @@ under the License.
 				<!-- mockito/powermock mismatch -->
 				<groupId>net.bytebuddy</groupId>
 				<artifactId>byte-buddy</artifactId>
-				<version>1.10.14</version>
+				<version>1.14.4</version>
 			</dependency>
 
 			<dependency>
 				<!-- mockito/powermock mismatch -->
 				<groupId>net.bytebuddy</groupId>
 				<artifactId>byte-buddy-agent</artifactId>
-				<version>1.10.14</version>
+				<version>1.14.4</version>
+			</dependency>
+
+			<!-- For dependency convergence -->
+			<dependency>
+				<groupId>net.java.dev.jna</groupId>
+				<artifactId>jna</artifactId>
+				<version>5.12.1</version>

Review Comment:
   From previous experience, we needed the version of the JNA to be in sync with the one used by Testcontainer, else all testcontainer upgrades fail with a rather indeterministic error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org