[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #14473: [Fix-14472][server] Fix the database connection parameters cannot take effect

["SbloodyS (via GitHub)" <gi...@apache.org>]

SbloodyS commented on code in PR #14473:
URL: https://github.com/apache/dolphinscheduler/pull/14473#discussion_r1255220918


##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/AbstractDataSourceProcessor.java:
##########
@@ -109,6 +109,6 @@ protected Map<String, String> transformOtherParamToMap(String other) {
     public String getDatasourceUniqueId(ConnectionParam connectionParam, DbType dbType) {
         BaseConnectionParam baseConnectionParam = (BaseConnectionParam) connectionParam;
         return MessageFormat.format("{0}@{1}@{2}@{3}", dbType.getDescp(), baseConnectionParam.getUser(),
-                PasswordUtils.encodePassword(baseConnectionParam.getPassword()), baseConnectionParam.getJdbcUrl());
+                PasswordUtils.encodePassword(baseConnectionParam.getPassword()), getJdbcUrl(connectionParam));

Review Comment:
   Is it better to update `org.apache.dolphinscheduler.plugin.datasource.api.plugin.DataSourceClientProvider#uniqueId2dataSourceClientCache` while calling `updateDataSource`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org