You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/26 09:02:56 UTC
[GitHub] maskit commented on a change in pull request #2829: Fix Websocket
Consume Messages in Partitioned Topics
maskit commented on a change in pull request #2829: Fix Websocket Consume Messages in Partitioned Topics
URL: https://github.com/apache/pulsar/pull/2829#discussion_r228454245
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageIdImpl.java
##########
@@ -31,7 +31,7 @@
private final String topicName;
private final MessageId messageId;
- TopicMessageIdImpl(String topicPartitionName, String topicName, MessageId messageId) {
+ public TopicMessageIdImpl(String topicPartitionName, String topicName, MessageId messageId) {
Review comment:
Is this public still needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services