[jira] [Updated] (SOLR-3913) SimplePostTool optimize does a redundant commit

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated SOLR-3913:
---------------------------------
    Labels: pull-request-available  (was: )

> SimplePostTool optimize does a redundant commit
> -----------------------------------------------
>
>                 Key: SOLR-3913
>                 URL: https://issues.apache.org/jira/browse/SOLR-3913
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>            Reporter: David Smiley
>            Assignee: Eric Pugh
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> At the end of SimplePostTool.execute() there is:
> {code}
>     if (commit)   commit();
>     if (optimize) optimize();
> {code}
> Each of these calls involves a separate request to Solr.  The thing is, an optimize internally commits, and so the logic should forgo committing is optimize is true.
> And as an aside, I think the 1kb pipe() buffer on line 893 is too small; it should be around 8kb (8192) bytes which is the same value as BufferedInputStream's default.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org