You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/12/08 11:36:28 UTC

[GitHub] [hudi] yanghua commented on a change in pull request #2307: [MINOR] Throw an exception when keyGenerator initialization failed in…

yanghua commented on a change in pull request #2307:
URL: https://github.com/apache/hudi/pull/2307#discussion_r538265716



##########
File path: hudi-flink/src/main/java/org/apache/hudi/source/JsonStringToHoodieRecordMapFunction.java
##########
@@ -65,10 +67,12 @@ public HoodieRecord map(String value) throws Exception {
   private void init() {
     this.props = StreamerUtil.getProps(cfg);
     avroConvertor = new AvroConvertor(new FilebasedSchemaProvider(props).getSourceSchema());
+    String keyGeneratorClass = props.getString("hoodie.datasource.write.keygenerator.class", SimpleAvroKeyGenerator.class.getName());
     try {
       keyGenerator = StreamerUtil.createKeyGenerator(props);
+      LOG.info("KeyGenerator {} initialized successfully", keyGeneratorClass);

Review comment:
       Should it be `info` level? What about `debug` level?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org