You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Pankraz76 (via GitHub)" <gi...@apache.org> on 2025/07/22 14:16:06 UTC
[PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Pankraz76 opened a new pull request, #20219:
URL: https://github.com/apache/kafka/pull/20219
refs:
- https://github.com/opensearch-project/OpenSearch/pull/18791
code seems to be out of sync considering large changes when applied:
<img width="1531" height="603" alt="image" src="https://github.com/user-attachments/assets/ca121671-befd-4e21-9457-48b9d28d982e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2232834298
##########
build.gradle:
##########
Review Comment:
Yes, thanks for pointing out.
Indeed, Rewrite has the ability to take over, making Spot and Check obsolete, considering the recipe:
- [AutoFormat Recipe - OpenRewrite Docs](https://docs.openrewrite.org/recipes/java/format/autoformat)
As a potential migration is too much for now, this PR is considered kind of PoC.
The import case is a good example - Rewrite has also bugs of course, but in this case seems to be stronger due to the type awareness.
Assuming Spot (which uses Google's formatter) is just a simple file parser like Checkstyle, it has a lot of blind spots in the unused imports theme again.
> 2\. Disabling import handling in one of the tools
yes shifted from spot to rewrite demonstrating the leftovers.
> * Using only Spotless for formatting/imports and Rewrite for code cleanup
yes thats the goal to later on check if spot is still necessary.
But first start small then continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PoC: Add `rewrite` support for `errorprone.refasterrules` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2537853793
##########
build.gradle:
##########
Review Comment:
this one seems to be a small starter as its quite established among other open source projects like gradle.
Kindly request some feedback on this:
- https://github.com/apache/kafka/pull/20688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `rewrite` support for `errorprone.refasterrules.FileRulesRecipes` [kafka]
Posted by "ravikalla (via GitHub)" <gi...@apache.org>.
ravikalla commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2233211714
##########
build.gradle:
##########
Review Comment:
Thanks for clarifying. I agree that starting small is better. Since you're demonstrating Rewrite's capabilities as a PoC, I suggest you to document in the PR description that this is exploring Rewrite as a potential Spotless replacement. For now, you can explicitly disable import handling in Spotless to avoid conflicts. Consider creating a follow-up issue to track the full migration evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PoC: Add `rewrite` support for `errorprone.refasterrules` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 closed pull request #20219: PoC: Add `rewrite` support for `errorprone.refasterrules`
URL: https://github.com/apache/kafka/pull/20219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PoC: Add `rewrite` support for `errorprone.refasterrules.FileRulesRecipes` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #20219:
URL: https://github.com/apache/kafka/pull/20219#issuecomment-3136548875
seems to work and be mergeable, kindly request some feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2232839720
##########
gradle.properties:
##########
@@ -14,6 +14,7 @@
# limitations under the License.
group=org.apache.kafka
+org.gradle.caching=true
Review Comment:
Right, thanks. This recipe/issue `GradleBestPractices` should then be done isolated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `rewrite` support for `errorprone.refasterrules.FileRulesRecipes` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #20219:
URL: https://github.com/apache/kafka/pull/20219#issuecomment-3122003233
```
BUILD SUCCESSFUL in 12m 31s
133 actionable tasks: 133 executed
16:38:11: Execution finished 'rewriteRun'.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2232843235
##########
build.gradle:
##########
@@ -16,6 +16,11 @@
import org.ajoberstar.grgit.Grgit
import java.nio.charset.StandardCharsets
+import static java.lang.Boolean.valueOf
Review Comment:
thanks.
##########
build.gradle:
##########
@@ -16,6 +16,11 @@
import org.ajoberstar.grgit.Grgit
import java.nio.charset.StandardCharsets
+import static java.lang.Boolean.valueOf
+import static java.lang.System.getenv
+import static java.lang.System.getenv
+import static java.util.Objects.isNull
Review Comment:
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2224910023
##########
gradlew:
##########
@@ -112,19 +114,6 @@ case "$( uname )" in #(
NONSTOP* ) nonstop=true ;;
esac
-
-# Loop in case we encounter an error.
Review Comment:
Thanks for advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2222806695
##########
gradlew:
##########
@@ -112,19 +114,6 @@ case "$( uname )" in #(
NONSTOP* ) nonstop=true ;;
esac
-
-# Loop in case we encounter an error.
Review Comment:
idk why its making this change.
@timtebeek
can you give me some context here plz?
the doc does not help me in this case.
- https://docs.gradle.org/current/userguide/best_practices_general.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2232874582
##########
build.gradle:
##########
@@ -224,6 +288,11 @@ allprojects {
delete "${projectDir}/src/generated"
delete "${projectDir}/src/generated-test"
}
+
+ // off switch for release: ' -x check' or ' -x rewriteDryRun spotlessJavaCheck'
+ tasks {
Review Comment:
moved to CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `rewrite` support for `errorprone.refasterrules.FileRulesRecipes` [kafka]
Posted by "ravikalla (via GitHub)" <gi...@apache.org>.
ravikalla commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2233216091
##########
gradle.properties:
##########
@@ -14,6 +14,7 @@
# limitations under the License.
group=org.apache.kafka
+org.gradle.caching=true
Review Comment:
Great, I agree. Please remove the build cache changes from this PR and create a separate PR for that change. It deserves its own discussion given the impact on all developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2223941640
##########
gradlew:
##########
@@ -112,19 +114,6 @@ case "$( uname )" in #(
NONSTOP* ) nonstop=true ;;
esac
-
-# Loop in case we encounter an error.
Review Comment:
We take the gradlew scripts as provided by gradle and apply those. You'll notice the reference script does not contain this block:
https://github.com/gradle/gradle/blob/master/platforms/jvm/plugins-application/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PoC: Add `rewrite` support for `errorprone.refasterrules.FileRulesRecipes` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #20219:
URL: https://github.com/apache/kafka/pull/20219#issuecomment-3135798224
BUILD SUCCESSFUL in 11m 26s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PoC: Add `rewrite` support for `errorprone.refasterrules` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #20219:
URL: https://github.com/apache/kafka/pull/20219#issuecomment-3194575434
closing as extracted:
- https://github.com/apache/kafka/pull/20314
- https://github.com/apache/kafka/pull/20365
Thanks for your guidance and feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2232838846
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##########
@@ -2998,15 +2993,6 @@ private void verifyVersionedTaskConverterFromWorker(String converterClassConfig,
verify(plugins).newConverter(any(WorkerConfig.class), eq(converterClassConfig), eq(converterVersionConfig));
}
- private void mockTaskHeaderConverter(ClassLoaderUsage classLoaderUsage, HeaderConverter returning) {
Review Comment:
## On Code Maintenance and Future-Proofing
Statements about potential future needs often overlook (software's) fundamental nature - that change is inevitable. The most maintainable systems recognize this reality through consistent pruning rather than speculative preservation.
- https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#unusedprivatemethod
- [S1144: Unused "private" methods should be removed](https://sonarsource.github.io/rspec/#/rspec/S1144)
Core Principles:
- **Active Usage Determines Value**: Code earns its place through current utility
- **The Preservation Paradox**: Keeping "just-in-case" code creates compounding costs
- **Carry Costs**: Unused code imposes maintenance overhead without delivering value
Static analysis provides objective measures to:
- **Surface Architectural Decay**: Identify unused or redundant elements
- **Quantify Technical Debt**: Measure the cost of preservation
- **Enable Data-Driven Decisions**: Replace speculation with metrics
The most sustainable approach recognizes:
1. All code requires ongoing validation of its purpose
2. Unused components represent decisions already made (through disuse)
3. Prevention scales better than retrospective cleanup
This perspective transforms maintenance from debate to process - where tools surface facts and systems evolve through measured iteration rather than speculative anticipation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2232839720
##########
gradle.properties:
##########
@@ -14,6 +14,7 @@
# limitations under the License.
group=org.apache.kafka
+org.gradle.caching=true
Review Comment:
Right, thanks. This recipe/issue should then be done isolated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `rewrite` support for `errorprone.refasterrules.FileRulesRecipes` [kafka]
Posted by "ravikalla (via GitHub)" <gi...@apache.org>.
ravikalla commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2233212635
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##########
@@ -2998,15 +2993,6 @@ private void verifyVersionedTaskConverterFromWorker(String converterClassConfig,
verify(plugins).newConverter(any(WorkerConfig.class), eq(converterClassConfig), eq(converterVersionConfig));
}
- private void mockTaskHeaderConverter(ClassLoaderUsage classLoaderUsage, HeaderConverter returning) {
Review Comment:
Those are valid points about avoiding speculative code preservation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2232846225
##########
build.gradle:
##########
@@ -16,6 +16,11 @@
import org.ajoberstar.grgit.Grgit
import java.nio.charset.StandardCharsets
+import static java.lang.Boolean.valueOf
+import static java.lang.System.getenv
+import static java.lang.System.getenv
Review Comment:
thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2232847588
##########
build.gradle:
##########
@@ -29,18 +34,77 @@ buildscript {
}
plugins {
- id 'com.github.ben-manes.versions' version '0.48.0'
- id 'idea'
- id 'jacoco'
- id 'java-library'
- id 'org.owasp.dependencycheck' version '8.2.1'
- id 'org.nosphere.apache.rat' version "0.8.1"
+ id "com.diffplug.spotless" version "7.2.1"
+ id "com.github.ben-manes.versions" version "0.48.0"
+ id "com.github.spotbugs" version "6.0.25" apply false
+ id "com.gradleup.shadow" version "8.3.6" apply false
+ id "idea"
id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}"
+ id "jacoco"
+ id "java-library"
+ id "org.nosphere.apache.rat" version "0.8.1"
+ id "org.openrewrite.rewrite" version "7.12.1"
+ id "org.owasp.dependencycheck" version "8.2.1"
+ id "org.scoverage" version "8.0.3" apply false
+}
+
+rewrite {
+ activeRecipe(
+ "org.openrewrite.gradle.GradleBestPractices",
+ "org.openrewrite.java.RemoveUnusedImports",
+ "org.openrewrite.staticanalysis.RemoveUnusedLocalVariables",
+ "org.openrewrite.staticanalysis.RemoveUnusedPrivateFields",
+ "org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods",
+ //"org.openrewrite.java.OrderImports",
+ //"org.openrewrite.java.format.RemoveTrailingWhitespace",
+ //"org.openrewrite.java.migrate.UpgradeToJava17",
+ //"org.openrewrite.java.migrate.util.MigrateCollectionsSingletonList",
+ //"org.openrewrite.java.migrate.util.MigrateCollectionsUnmodifiableList",
+ //"org.openrewrite.java.recipes.JavaRecipeBestPractices",
+ //"org.openrewrite.java.recipes.RecipeNullabilityBestPractices",
+ //"org.openrewrite.java.recipes.RecipeTestingBestPractices",
+ //"org.openrewrite.staticanalysis.CodeCleanup",
+ //"org.openrewrite.staticanalysis.EmptyBlock",
+ //"org.openrewrite.staticanalysis.EqualsAvoidsNull",
+ //"org.openrewrite.staticanalysis.JavaApiBestPractices",
+ //"org.openrewrite.staticanalysis.MissingOverrideAnnotation",
+ //"org.openrewrite.staticanalysis.ModifierOrder",
+ //"org.openrewrite.staticanalysis.NoFinalizer",
+ //"org.openrewrite.staticanalysis.RemoveCallsToSystemGc",
+ //"org.openrewrite.staticanalysis.RemoveUnneededAssertion",
+ //"org.openrewrite.staticanalysis.StringLiteralEquality",
+ //"org.openrewrite.staticanalysis.UnnecessaryParentheses",
+ //"org.openrewrite.staticanalysis.UnnecessaryThrows",
+ //"org.openrewrite.text.EndOfLineAtEndOfFile",
+ //"tech.picnic.errorprone.refasterrules.CollectionRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.FileRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.NullRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.NullRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.StreamRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.StringRulesRecipes",
+ // running active recipes: tech.picnic.errorprone.refasterrules.NullRulesRecipes
+ //<============-> 99% EXECUTING [1h 38s]
Review Comment:
thanks for executing, yes this is really an burden.
Lets shirt this into an dedicated PR once the foundation is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #20219:
URL: https://github.com/apache/kafka/pull/20219#issuecomment-3121737804
> The PR is marked as "[Experimental]" but makes changes that would affect all developers immediately. This includes modifying the main build configuration, adding new required tasks to the check lifecycle, enabling build caching globally, and changing existing tool configurations. For an experimental feature, I'd suggest using a separate build file or opt-in flag instead. It would also be helpful to create a feature branch for testing, provide a way to disable the rewrite checks, and add proper documentation about the experimental nature of these changes.
Maybe `[PoC]` would reflect my intention better as this is just some suggestion offered.
It needs to be wanted and pulled by the dev team, as it's a conventional change, not designed to opt in, as the nature of this can be (once) invasive and is meant to sustain therefore be constantly checked against. Same approach like spot but more flexible.
I would suggest to make a decision about using the potential benefit this tool has to offer and then integrate it non-breaking/colliding with anything of course, making it ready (opt-in/out) to be removed afterwards again, if it turns out, not to be practical.
The import statement is a good starter and the removals as they should flag only once and non-critical stuff as overhead is normally obsolete, ready to be reconsidered and resolved.
As the task is meant to run in cloud only it's about time and stability, as the recipes are individual.
Only the dev teams choose which to leverage and apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `rewrite` support for `errorprone.refasterrules.FileRulesRecipes` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2233067242
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##########
@@ -2998,15 +2993,6 @@ private void verifyVersionedTaskConverterFromWorker(String converterClassConfig,
verify(plugins).newConverter(any(WorkerConfig.class), eq(converterClassConfig), eq(converterVersionConfig));
}
- private void mockTaskHeaderConverter(ClassLoaderUsage classLoaderUsage, HeaderConverter returning) {
Review Comment:
same applies for the fields, its a general decision to be made. Let me know if i should undo them too. Kindly request your critics again, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `rewrite` support for `errorprone.refasterrules.FileRulesRecipes` [kafka]
Posted by "ravikalla (via GitHub)" <gi...@apache.org>.
ravikalla commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2233216595
##########
build.gradle:
##########
@@ -224,6 +288,11 @@ allprojects {
delete "${projectDir}/src/generated"
delete "${projectDir}/src/generated-test"
}
+
+ // off switch for release: ' -x check' or ' -x rewriteDryRun spotlessJavaCheck'
+ tasks {
Review Comment:
Perfect! This allows the experimental validation without disrupting developer workflows. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "ravikalla (via GitHub)" <gi...@apache.org>.
ravikalla commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2231508798
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##########
@@ -2998,15 +2993,6 @@ private void verifyVersionedTaskConverterFromWorker(String converterClassConfig,
verify(plugins).newConverter(any(WorkerConfig.class), eq(converterClassConfig), eq(converterVersionConfig));
}
- private void mockTaskHeaderConverter(ClassLoaderUsage classLoaderUsage, HeaderConverter returning) {
Review Comment:
Several private test helper methods like 'mockTaskConverter', 'mockTaskHeaderConverter', and 'autoCreateTopicsConfigs' were removed. While these appear unused now, they might be valuable test utilities.
Need to verify:
1. Were these methods recently added for upcoming features?
2. Could they be useful for future test cases?
3. Should they be preserved but marked with @SuppressWarnings("unused") if they're intentionally kept for future use?
##########
README.md:
##########
@@ -201,7 +201,12 @@ For experiments (or regression testing purposes) add `-PcheckstyleVersion=X.y.z`
#### Spotless ####
The import order is a part of static check. please call `spotlessApply` to optimize the imports of Java codes before filing pull request.
- ./gradlew spotlessApply
+`./gradlew spotlessApply`
+
+#### Rewrite ####
+The import order is a part of static check. please call `rewriteRun` to optimize the imports of Java codes before filing pull request.
+
+`./gradlew rewriteRun`
Review Comment:
"The import order is a part of static check" appears to be copy-pasted from the Spotless section. The Rewrite plugin does much more than just import ordering - it removes unused code, fields, and methods. This documentation should accurately describe what rewriteRun actually does.
##########
build.gradle:
##########
Review Comment:
Both Spotless and Rewrite are configured to handle imports: Spotless has importOrder() configuration and Rewrite has RemoveUnusedImports recipe active.
This creates overlapping responsibilities and potential conflicts. Consider either:
1. Using only Spotless for formatting/imports and Rewrite for code cleanup
2. Disabling import handling in one of the tools
##########
gradle.properties:
##########
@@ -14,6 +14,7 @@
# limitations under the License.
group=org.apache.kafka
+org.gradle.caching=true
Review Comment:
This enables Gradle's build cache. This is a significant change that affects build behavior and should be documented in the PR description as it affects all developers. Also, add some documentation on cache invalidation and troubleshooting. Also, see if local and/or remote caching should be configured aswell.
##########
build.gradle:
##########
@@ -224,6 +288,11 @@ allprojects {
delete "${projectDir}/src/generated"
delete "${projectDir}/src/generated-test"
}
+
+ // off switch for release: ' -x check' or ' -x rewriteDryRun spotlessJavaCheck'
+ tasks {
Review Comment:
This is to check task dependencies. But this will fail builds if any of the rewrite recipes detect issues.
Also, the failOnDryRunResults = true setting means CI will break for any unused code and this is a breaking change for developers who might have unused private methods in their working branches.
Consider making this opt-in initially or only enabled in CI.
##########
build.gradle:
##########
@@ -16,6 +16,11 @@
import org.ajoberstar.grgit.Grgit
import java.nio.charset.StandardCharsets
+import static java.lang.Boolean.valueOf
+import static java.lang.System.getenv
+import static java.lang.System.getenv
Review Comment:
Duplicate import
##########
build.gradle:
##########
@@ -29,18 +34,77 @@ buildscript {
}
plugins {
- id 'com.github.ben-manes.versions' version '0.48.0'
- id 'idea'
- id 'jacoco'
- id 'java-library'
- id 'org.owasp.dependencycheck' version '8.2.1'
- id 'org.nosphere.apache.rat' version "0.8.1"
+ id "com.diffplug.spotless" version "7.2.1"
+ id "com.github.ben-manes.versions" version "0.48.0"
+ id "com.github.spotbugs" version "6.0.25" apply false
+ id "com.gradleup.shadow" version "8.3.6" apply false
+ id "idea"
id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}"
+ id "jacoco"
+ id "java-library"
+ id "org.nosphere.apache.rat" version "0.8.1"
+ id "org.openrewrite.rewrite" version "7.12.1"
+ id "org.owasp.dependencycheck" version "8.2.1"
+ id "org.scoverage" version "8.0.3" apply false
+}
+
+rewrite {
+ activeRecipe(
+ "org.openrewrite.gradle.GradleBestPractices",
+ "org.openrewrite.java.RemoveUnusedImports",
+ "org.openrewrite.staticanalysis.RemoveUnusedLocalVariables",
+ "org.openrewrite.staticanalysis.RemoveUnusedPrivateFields",
+ "org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods",
+ //"org.openrewrite.java.OrderImports",
+ //"org.openrewrite.java.format.RemoveTrailingWhitespace",
+ //"org.openrewrite.java.migrate.UpgradeToJava17",
+ //"org.openrewrite.java.migrate.util.MigrateCollectionsSingletonList",
+ //"org.openrewrite.java.migrate.util.MigrateCollectionsUnmodifiableList",
+ //"org.openrewrite.java.recipes.JavaRecipeBestPractices",
+ //"org.openrewrite.java.recipes.RecipeNullabilityBestPractices",
+ //"org.openrewrite.java.recipes.RecipeTestingBestPractices",
+ //"org.openrewrite.staticanalysis.CodeCleanup",
+ //"org.openrewrite.staticanalysis.EmptyBlock",
+ //"org.openrewrite.staticanalysis.EqualsAvoidsNull",
+ //"org.openrewrite.staticanalysis.JavaApiBestPractices",
+ //"org.openrewrite.staticanalysis.MissingOverrideAnnotation",
+ //"org.openrewrite.staticanalysis.ModifierOrder",
+ //"org.openrewrite.staticanalysis.NoFinalizer",
+ //"org.openrewrite.staticanalysis.RemoveCallsToSystemGc",
+ //"org.openrewrite.staticanalysis.RemoveUnneededAssertion",
+ //"org.openrewrite.staticanalysis.StringLiteralEquality",
+ //"org.openrewrite.staticanalysis.UnnecessaryParentheses",
+ //"org.openrewrite.staticanalysis.UnnecessaryThrows",
+ //"org.openrewrite.text.EndOfLineAtEndOfFile",
+ //"tech.picnic.errorprone.refasterrules.CollectionRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.FileRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.NullRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.NullRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.StreamRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.StringRulesRecipes",
+ // running active recipes: tech.picnic.errorprone.refasterrules.NullRulesRecipes
+ //<============-> 99% EXECUTING [1h 38s]
Review Comment:
As this recipe took over 1.5 hours to run, this is concerning for developer productivity. Careful evaluation is required as it is taking very long - I would get it reviewed by someone else.
##########
build.gradle:
##########
@@ -16,6 +16,11 @@
import org.ajoberstar.grgit.Grgit
import java.nio.charset.StandardCharsets
+import static java.lang.Boolean.valueOf
Review Comment:
Unused import
##########
build.gradle:
##########
@@ -16,6 +16,11 @@
import org.ajoberstar.grgit.Grgit
import java.nio.charset.StandardCharsets
+import static java.lang.Boolean.valueOf
+import static java.lang.System.getenv
+import static java.lang.System.getenv
+import static java.util.Objects.isNull
Review Comment:
Unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2232874658
##########
README.md:
##########
@@ -201,7 +201,12 @@ For experiments (or regression testing purposes) add `-PcheckstyleVersion=X.y.z`
#### Spotless ####
The import order is a part of static check. please call `spotlessApply` to optimize the imports of Java codes before filing pull request.
- ./gradlew spotlessApply
+`./gradlew spotlessApply`
+
+#### Rewrite ####
+The import order is a part of static check. please call `rewriteRun` to optimize the imports of Java codes before filing pull request.
+
+`./gradlew rewriteRun`
Review Comment:
thanks, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PoC: Add `rewrite` support for `errorprone.refasterrules.FileRulesRecipes` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2244732670
##########
.github/workflows/build.yml:
##########
@@ -140,7 +140,12 @@ jobs:
# --scan: Publish the build scan. This will only work on PRs from apache/kafka and trunk
# --no-scan: For public fork PRs, we won't attempt to publish the scan
run: |
- ./gradlew --build-cache --info $SCAN_ARG check releaseTarGz -x test
+ ./gradlew check --build-cache --info $SCAN_ARG releaseTarGz -x test
Review Comment:
as we checking but the QA is executed just on test:
- https://github.com/apache/kafka/pull/20259/files#r2244732262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2222808362
##########
gradle/wrapper/gradle-wrapper.properties:
##########
@@ -1,7 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionSha256Sum=845952a9d6afa783db70bb3b0effaae45ae5542ca2bb7929619e8af49cb634cf
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.1-bin.zip
Review Comment:
does dependabot not check for this?
##########
build.gradle:
##########
@@ -29,18 +34,43 @@ buildscript {
}
plugins {
- id 'com.github.ben-manes.versions' version '0.48.0'
- id 'idea'
- id 'jacoco'
- id 'java-library'
- id 'org.owasp.dependencycheck' version '8.2.1'
- id 'org.nosphere.apache.rat' version "0.8.1"
+ id "com.diffplug.spotless" version "7.2.1"
+ id "com.github.ben-manes.versions" version "0.48.0"
+ id "com.github.spotbugs" version "6.0.25" apply false
+ id "com.gradleup.shadow" version "8.3.6" apply false
+ id "idea"
id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}"
+ id "jacoco"
+ id "java-library"
+ id "org.nosphere.apache.rat" version "0.8.1"
+ id "org.openrewrite.rewrite" version "7.10.0"
+ id "org.owasp.dependencycheck" version "8.2.1"
+ id "org.scoverage" version "8.0.3" apply false
+}
+
+rewrite {
+ activeRecipe("org.openrewrite.gradle.GradleBestPractices")
+ activeRecipe("org.openrewrite.java.RemoveUnusedImports")
+ activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedLocalVariables")
+ activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedPrivateFields")
+ activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods")
+ failOnDryRunResults = true
+}
+
+spotless {
+ java {
+ targetExclude('**/generated/**/*.java','**/generated-test/**/*.java')
+ importOrder('kafka', 'org.apache.kafka', 'com', 'net', 'org', 'java', 'javax', '', '\\#')
+ //licenseHeaderFile("$rootDir/checkstyle/java.header", 'package') todo apply me
+ }
+ scala {
+ scalafmt("$versions.scalafmt").configFile("$rootDir/checkstyle/.scalafmt.conf").scalaMajorVersion(versions.baseScala)
+ //licenseHeaderFile("$rootDir/checkstyle/java.header", 'package') todo apply me
+ }
+}
- id "com.github.spotbugs" version '6.0.25' apply false
- id 'org.scoverage' version '8.0.3' apply false
- id 'com.gradleup.shadow' version '8.3.6' apply false
- id 'com.diffplug.spotless' version "6.25.0"
Review Comment:
does dependabot not check for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #20219:
URL: https://github.com/apache/kafka/pull/20219#issuecomment-3117403438
```
BUILD SUCCESSFUL in 38m 46s
374 actionable tasks: 90 executed, 284 up-to-date
➜ kafka git:(rewrite-) ./gradlew build -x test
```
Kindly request your feedback. Thanks for consideration.
Is this is any good?
@m1a2st
@sjhajharia
@ravikalla
@apoorvmittal10
@CalvinConfluent
@chia7712
@frankvicky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2232847588
##########
build.gradle:
##########
@@ -29,18 +34,77 @@ buildscript {
}
plugins {
- id 'com.github.ben-manes.versions' version '0.48.0'
- id 'idea'
- id 'jacoco'
- id 'java-library'
- id 'org.owasp.dependencycheck' version '8.2.1'
- id 'org.nosphere.apache.rat' version "0.8.1"
+ id "com.diffplug.spotless" version "7.2.1"
+ id "com.github.ben-manes.versions" version "0.48.0"
+ id "com.github.spotbugs" version "6.0.25" apply false
+ id "com.gradleup.shadow" version "8.3.6" apply false
+ id "idea"
id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}"
+ id "jacoco"
+ id "java-library"
+ id "org.nosphere.apache.rat" version "0.8.1"
+ id "org.openrewrite.rewrite" version "7.12.1"
+ id "org.owasp.dependencycheck" version "8.2.1"
+ id "org.scoverage" version "8.0.3" apply false
+}
+
+rewrite {
+ activeRecipe(
+ "org.openrewrite.gradle.GradleBestPractices",
+ "org.openrewrite.java.RemoveUnusedImports",
+ "org.openrewrite.staticanalysis.RemoveUnusedLocalVariables",
+ "org.openrewrite.staticanalysis.RemoveUnusedPrivateFields",
+ "org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods",
+ //"org.openrewrite.java.OrderImports",
+ //"org.openrewrite.java.format.RemoveTrailingWhitespace",
+ //"org.openrewrite.java.migrate.UpgradeToJava17",
+ //"org.openrewrite.java.migrate.util.MigrateCollectionsSingletonList",
+ //"org.openrewrite.java.migrate.util.MigrateCollectionsUnmodifiableList",
+ //"org.openrewrite.java.recipes.JavaRecipeBestPractices",
+ //"org.openrewrite.java.recipes.RecipeNullabilityBestPractices",
+ //"org.openrewrite.java.recipes.RecipeTestingBestPractices",
+ //"org.openrewrite.staticanalysis.CodeCleanup",
+ //"org.openrewrite.staticanalysis.EmptyBlock",
+ //"org.openrewrite.staticanalysis.EqualsAvoidsNull",
+ //"org.openrewrite.staticanalysis.JavaApiBestPractices",
+ //"org.openrewrite.staticanalysis.MissingOverrideAnnotation",
+ //"org.openrewrite.staticanalysis.ModifierOrder",
+ //"org.openrewrite.staticanalysis.NoFinalizer",
+ //"org.openrewrite.staticanalysis.RemoveCallsToSystemGc",
+ //"org.openrewrite.staticanalysis.RemoveUnneededAssertion",
+ //"org.openrewrite.staticanalysis.StringLiteralEquality",
+ //"org.openrewrite.staticanalysis.UnnecessaryParentheses",
+ //"org.openrewrite.staticanalysis.UnnecessaryThrows",
+ //"org.openrewrite.text.EndOfLineAtEndOfFile",
+ //"tech.picnic.errorprone.refasterrules.CollectionRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.FileRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.NullRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.NullRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.StreamRulesRecipes",
+ //"tech.picnic.errorprone.refasterrules.StringRulesRecipes",
+ // running active recipes: tech.picnic.errorprone.refasterrules.NullRulesRecipes
+ //<============-> 99% EXECUTING [1h 38s]
Review Comment:
thanks for executing, yes this is really an burden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `rewrite` support for `errorprone.refasterrules.FileRulesRecipes` [kafka]
Posted by "ravikalla (via GitHub)" <gi...@apache.org>.
ravikalla commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2233214833
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##########
@@ -2998,15 +2993,6 @@ private void verifyVersionedTaskConverterFromWorker(String converterClassConfig,
verify(plugins).newConverter(any(WorkerConfig.class), eq(converterClassConfig), eq(converterVersionConfig));
}
- private void mockTaskHeaderConverter(ClassLoaderUsage classLoaderUsage, HeaderConverter returning) {
Review Comment:
For this specific case, I'm satisfied with removing these unused test utilities. However, it would be helpful to add a note in the PR description listing what was removed, so reviewers can verify nothing critical was deleted. Also, consider running this cleanup as a separate PR in the future to make reviews easier.
Regarding fields - yes, please apply the same approach consistently. Remove unused fields as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PoC: Add `rewrite` support for `errorprone.refasterrules` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2247917367
##########
build.gradle:
##########
Review Comment:
As the overall time could potentially exceed 1 hours its an cost factor to consider.
If its got some "free" runners it should be no problem to wait the full time.
Only apply is then an issue on root. Assuming most changes are limited to certain sub projects it should be possible then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PoC: Add `rewrite` support for `errorprone.refasterrules` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2247917367
##########
build.gradle:
##########
Review Comment:
As the overall time could potentially exceed 1 hours its an cost factor to consider.
If its got some "free" runners it should be no problem to wait.
Only the apply could be an issue on root lvl.
Assuming most changes are limited to certain sub projects, it should be possible then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PoC: Add `rewrite` support for `errorprone.refasterrules` [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #20219:
URL: https://github.com/apache/kafka/pull/20219#issuecomment-3158149355
kindly request some feedback on enabler:
- https://github.com/apache/kafka/pull/20314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org