You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/25 22:34:17 UTC
[GitHub] [zookeeper] blb93 opened a new pull request #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
blb93 opened a new pull request #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
URL: https://github.com/apache/zookeeper/pull/1271
…n the FinalRequestProcessor#processRequest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] blb93 commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
Posted by GitBox <gi...@apache.org>.
blb93 commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
URL: https://github.com/apache/zookeeper/pull/1271#issuecomment-604161659
@maoling @eolivelli Is this in the correct state to be merged in? a little confused on the Jira/Github contributor etiquette and want to confirm I have this/jira item in the appropriate state. Hoping to understand the flow before I help with additional items. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
URL: https://github.com/apache/zookeeper/pull/1271#issuecomment-604485029
Btw the patch is quite straightforward so maybe I can commit anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli closed pull request #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
URL: https://github.com/apache/zookeeper/pull/1271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] blb93 commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
Posted by GitBox <gi...@apache.org>.
blb93 commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
URL: https://github.com/apache/zookeeper/pull/1271#issuecomment-604618353
@eolivelli Thank you for the clarification! I definitely thought maoling had write access. It makes sense now. I've also just fixed the merge conflicts that came up. It is straightforward, so up to you, but I will try and get a secondary approval in the meantime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] phunt commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
Posted by GitBox <gi...@apache.org>.
phunt commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
URL: https://github.com/apache/zookeeper/pull/1271#issuecomment-604697966
+1 lgtm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1271: ZOOKEEPER-3728: move traceMask calculation logic into the trace log i…
URL: https://github.com/apache/zookeeper/pull/1271#issuecomment-604484717
In order to commit a patch we are used to wait for at least two *binding* approvals.
In this case my approval is binding and we need another one.
Hopefully one day @maoling will have write access (and so binding vote)
We just need a second sponsor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services