You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/15 20:25:29 UTC

[GitHub] [commons-vfs] garydgregory commented on pull request #20: AbstractFileObject: call doGetType() without holding the lock

garydgregory commented on pull request #20:
URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-880989991


   I am trying to digest this into manageable chunks and I see a standalone edit to `SftpFileObject` that adds `synchronized` to three method declarations. Those three methods deal with the mutable and thread-unsafe `com.jcraft.jsch.SftpATTRS`. Why just those three methods? I do not know but it seems that all access to this SftpATTRS should be synchronized, so I added `synchronized` to the methods that read or write the SftpATTRS instance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org