You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2016/02/11 01:12:55 UTC

Review Request 43460: SQOOP-2831: Sqoop2: Precommit: Do not run multiple execution for integration tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43460/
-----------------------------------------------------------

Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-2831
    https://issues.apache.org/jira/browse/SQOOP-2831


Repository: sqoop-sqoop2


Description
-------

We have several [different "executions" defined in our integration tests|https://github.com/apache/sqoop/blob/sqoop2/test/pom.xml#L214]. It seems that our purpose was to run one suite per execution, but the side effect is that it's hard to run one single tests as my usual command line:

{code}
mvn clean integration-test -pl test -Dtest=$TEST
{code}

Will execute the test {{$TEST}} once for each execution defined.

It seems that maven surefire plugin supports [multiple suites per single execution|http://maven.apache.org/surefire/maven-surefire-plugin/examples/testng.html], so I'm wondering if that will work for us as well.


Diffs
-----

  test/pom.xml 134bca1 

Diff: https://reviews.apache.org/r/43460/diff/


Testing
-------


Thanks,

Jarek Cecho


Re: Review Request 43460: SQOOP-2831: Sqoop2: Precommit: Do not run multiple execution for integration tests

Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43460/#review118904
-----------------------------------------------------------


Ship it!




Ship It!

- Abraham Fine


On Feb. 11, 2016, 12:12 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43460/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 12:12 a.m.)
> 
> 
> Review request for Sqoop and Jarek Cecho.
> 
> 
> Bugs: SQOOP-2831
>     https://issues.apache.org/jira/browse/SQOOP-2831
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> We have several [different "executions" defined in our integration tests|https://github.com/apache/sqoop/blob/sqoop2/test/pom.xml#L214]. It seems that our purpose was to run one suite per execution, but the side effect is that it's hard to run one single tests as my usual command line:
> 
> {code}
> mvn clean integration-test -pl test -Dtest=$TEST
> {code}
> 
> Will execute the test {{$TEST}} once for each execution defined.
> 
> It seems that maven surefire plugin supports [multiple suites per single execution|http://maven.apache.org/surefire/maven-surefire-plugin/examples/testng.html], so I'm wondering if that will work for us as well.
> 
> 
> Diffs
> -----
> 
>   test/pom.xml 134bca1 
> 
> Diff: https://reviews.apache.org/r/43460/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>