You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "asl3 (via GitHub)" <gi...@apache.org> on 2023/07/07 22:53:25 UTC
[GitHub] [spark] asl3 opened a new pull request, #41896: Add new pyspark_testing module, update GHA
asl3 opened a new pull request, #41896:
URL: https://github.com/apache/spark/pull/41896
### What changes were proposed in this pull request?
This PR adds a new module and modifies GHA for `pyspark.testing.utils` doctests.
### Why are the changes needed?
This change ensures that doctests are run for the file, since `pyspark.testing.utils` now contains user-facing APIs with docstrings
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41896: [SPARK-44357] [PYTHON] Add pyspark_testing module for GHA tests
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41896:
URL: https://github.com/apache/spark/pull/41896#issuecomment-1630067266
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a diff in pull request #41896: Add new pyspark_testing module, update GHA
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on code in PR #41896:
URL: https://github.com/apache/spark/pull/41896#discussion_r1258635004
##########
dev/sparktestsupport/modules.py:
##########
@@ -507,6 +507,16 @@ def __hash__(self):
],
)
+pyspark_testing = Module(
+ name="pyspark-testing",
+ dependencies=[pyspark_core, pyspark_sql],
+ source_file_regexes=["python/pyspark/testing"],
+ python_test_goals=[
+ # doctests
+ "pyspark.testing.utils",
Review Comment:
Need to remove this entry from `pyspark-sql` module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #41896: [SPARK-44357] [PYTHON] Add pyspark_testing module for GHA tests
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41896: [SPARK-44357] [PYTHON] Add pyspark_testing module for GHA tests
URL: https://github.com/apache/spark/pull/41896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org