[GitHub] [ozone] kaijchen commented on a diff in pull request #3372: HDDS-6400. EC: Refactor ECKeyOutputStream for better code reuse

[GitBox <gi...@apache.org>]

kaijchen commented on code in PR #3372:
URL: https://github.com/apache/ozone/pull/3372#discussion_r866917897


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java:
##########
@@ -660,6 +515,45 @@ private ByteBuffer[] getParityBuffers() {
       return parityBuffers;
     }
 
+    private long getDataSize() {
+      return Arrays.stream(dataBuffers)
+          .mapToInt(Buffer::position)
+          .asLongStream()
+          .sum();
+    }
+
+    private boolean isPartialStripe() {
+      return dataBuffers[0].position() > 0 &&
+          dataBuffers[dataBuffers.length - 1].position() < cellSize;
+    }
+

Review Comment:
   OK, I will change it to outside.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org