You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/01/07 11:01:32 UTC
Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-912
https://issues.apache.org/jira/browse/LENS-912
Repository: lens
Description
-------
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java e7550ca2c8307cba086e848e8b476a670366f7a5
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
Diff: https://reviews.apache.org/r/42022/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Jan. 13, 2016, 7:29 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, line 134
> > <https://reviews.apache.org/r/42022/diff/2/?file=1186196#file1186196line134>
> >
> > Can you check this with Hive 2.1 and see if we have to remove isCubeNode fully ?
>
> Rajat Khandelwal wrote:
> Yes. As in we don't *need* to remove it, but the function will never return true with Hive >= 2.1
It may not even generate AST with Hive 2.1, if the query has a cube keyword. We might have to do a replace "cube select " with "select ", even before generating AST. Please check.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review114156
-----------------------------------------------------------
On Jan. 7, 2016, 11:06 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 11:06 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java e7550ca2c8307cba086e848e8b476a670366f7a5
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Jan. 13, 2016, 12:59 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, line 58
> > <https://reviews.apache.org/r/42022/diff/2/?file=1186196#file1186196line58>
> >
> > Why are we creating static client? Please add comments.
>
> Rajat Khandelwal wrote:
> The util needs to know whether a table is a cube table or not. For that `CubeMetastoreClient` instance is required. Hence created a static client for the entire utility to use.
getting hiveconf from query now to get the cubemetastoreclient instance.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review114156
-----------------------------------------------------------
On Jan. 7, 2016, 4:36 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 4:36 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java e7550ca2c8307cba086e848e8b476a670366f7a5
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Jan. 13, 2016, 12:59 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, line 134
> > <https://reviews.apache.org/r/42022/diff/2/?file=1186196#file1186196line134>
> >
> > Can you check this with Hive 2.1 and see if we have to remove isCubeNode fully ?
>
> Rajat Khandelwal wrote:
> Yes. As in we don't *need* to remove it, but the function will never return true with Hive >= 2.1
>
> Amareshwari Sriramadasu wrote:
> It may not even generate AST with Hive 2.1, if the query has a cube keyword. We might have to do a replace "cube select " with "select ", even before generating AST. Please check.
Yes, I've added code for that in my local environment. Trying to run example queries now. Will update review request.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review114156
-----------------------------------------------------------
On Jan. 7, 2016, 4:36 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 4:36 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java e7550ca2c8307cba086e848e8b476a670366f7a5
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Jan. 13, 2016, 12:59 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, line 58
> > <https://reviews.apache.org/r/42022/diff/2/?file=1186196#file1186196line58>
> >
> > Why are we creating static client? Please add comments.
The util needs to know whether a table is a cube table or not. For that `CubeMetastoreClient` instance is required. Hence created a static client for the entire utility to use.
> On Jan. 13, 2016, 12:59 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, line 63
> > <https://reviews.apache.org/r/42022/diff/2/?file=1186196#file1186196line63>
> >
> > why are we creating a new HiveConf(), it may not talk to the correct metastore.
will pass query's hiveconf to get instance.
> On Jan. 13, 2016, 12:59 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, line 134
> > <https://reviews.apache.org/r/42022/diff/2/?file=1186196#file1186196line134>
> >
> > Can you check this with Hive 2.1 and see if we have to remove isCubeNode fully ?
Yes. As in we don't *need* to remove it, but the function will never return true with Hive >= 2.1
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review114156
-----------------------------------------------------------
On Jan. 7, 2016, 4:36 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 4:36 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java e7550ca2c8307cba086e848e8b476a670366f7a5
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review114156
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java (line 58)
<https://reviews.apache.org/r/42022/#comment174988>
Why are we creating static client? Please add comments.
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java (line 63)
<https://reviews.apache.org/r/42022/#comment174989>
why are we creating a new HiveConf(), it may not talk to the correct metastore.
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java (line 134)
<https://reviews.apache.org/r/42022/#comment174990>
Can you check this with Hive 2.1 and see if we have to remove isCubeNode fully ?
- Amareshwari Sriramadasu
On Jan. 7, 2016, 11:06 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 11:06 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java e7550ca2c8307cba086e848e8b476a670366f7a5
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Jan. 19, 2016, 11:45 a.m., Amareshwari Sriramadasu wrote:
> > Can you run examples with the changes and update ?
Yes, have run. 148/148 succeeded. In fact, some of the test cases are inspired by examples. Some cases were not getting covered in tests but were getting covered in examples. :)
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review115115
-----------------------------------------------------------
On Jan. 18, 2016, 11:44 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 11:44 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
> lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
> lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review115115
-----------------------------------------------------------
Can you run examples with the changes and update ?
- Amareshwari Sriramadasu
On Jan. 18, 2016, 6:14 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 6:14 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
> lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
> lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review115787
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java (line 57)
<https://reviews.apache.org/r/42022/#comment176843>
Whats the hack here?
lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java (line 34)
<https://reviews.apache.org/r/42022/#comment176844>
Can you update user guide saying cube keyword is optional ?
- Amareshwari Sriramadasu
On Jan. 20, 2016, 12:55 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 12:55 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 08192bdf4821ae55bc6c41623ff3d711324a24c7
> lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5
> lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Jan. 25, 2016, 6:19 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java, line 81
> > <https://reviews.apache.org/r/42022/diff/8/?file=1205389#file1205389line81>
> >
> > Check if this number needs to changed
Updated to fail late
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review116083
-----------------------------------------------------------
On Jan. 25, 2016, 7:18 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 7:18 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 08192bdf4821ae55bc6c41623ff3d711324a24c7
> lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5
> lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
> src/site/apt/user/olap-cube.apt c47ac303803e5437a66b4f488b228a6b3c495809
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review116083
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java (line 81)
<https://reviews.apache.org/r/42022/#comment177084>
Check if this number needs to changed
- Amareshwari Sriramadasu
On Jan. 22, 2016, 6:44 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 6:44 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 08192bdf4821ae55bc6c41623ff3d711324a24c7
> lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5
> lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
> src/site/apt/user/olap-cube.apt c47ac303803e5437a66b4f488b228a6b3c495809
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 1:05 p.m.)
Review request for lens.
Bugs: LENS-912
https://issues.apache.org/jira/browse/LENS-912
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 08192bdf4821ae55bc6c41623ff3d711324a24c7
lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5
lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
src/site/apt/user/olap-cube.apt c47ac303803e5437a66b4f488b228a6b3c495809
Diff: https://reviews.apache.org/r/42022/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review116538
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Jan. 25, 2016, 1:48 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 1:48 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 08192bdf4821ae55bc6c41623ff3d711324a24c7
> lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5
> lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
> src/site/apt/user/olap-cube.apt c47ac303803e5437a66b4f488b228a6b3c495809
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/
-----------------------------------------------------------
(Updated Jan. 25, 2016, 7:18 p.m.)
Review request for lens.
Bugs: LENS-912
https://issues.apache.org/jira/browse/LENS-912
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 08192bdf4821ae55bc6c41623ff3d711324a24c7
lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5
lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
src/site/apt/user/olap-cube.apt c47ac303803e5437a66b4f488b228a6b3c495809
Diff: https://reviews.apache.org/r/42022/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 12:14 p.m.)
Review request for lens.
Bugs: LENS-912
https://issues.apache.org/jira/browse/LENS-912
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 08192bdf4821ae55bc6c41623ff3d711324a24c7
lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5
lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
src/site/apt/user/olap-cube.apt c47ac303803e5437a66b4f488b228a6b3c495809
Diff: https://reviews.apache.org/r/42022/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 11:59 a.m.)
Review request for lens.
Bugs: LENS-912
https://issues.apache.org/jira/browse/LENS-912
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 08192bdf4821ae55bc6c41623ff3d711324a24c7
lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5
lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
src/site/apt/user/olap-cube.apt c47ac303803e5437a66b4f488b228a6b3c495809
Diff: https://reviews.apache.org/r/42022/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 11:40 a.m.)
Review request for lens.
Bugs: LENS-912
https://issues.apache.org/jira/browse/LENS-912
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 08192bdf4821ae55bc6c41623ff3d711324a24c7
lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5
lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
src/site/apt/user/olap-cube.apt c47ac303803e5437a66b4f488b228a6b3c495809
Diff: https://reviews.apache.org/r/42022/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 6:25 p.m.)
Review request for lens.
Bugs: LENS-912
https://issues.apache.org/jira/browse/LENS-912
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 08192bdf4821ae55bc6c41623ff3d711324a24c7
lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5
lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
Diff: https://reviews.apache.org/r/42022/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review115121
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Jan. 18, 2016, 6:14 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 6:14 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
> lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
> lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/
-----------------------------------------------------------
(Updated Jan. 18, 2016, 11:44 a.m.)
Review request for lens.
Bugs: LENS-912
https://issues.apache.org/jira/browse/LENS-912
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
Diff: https://reviews.apache.org/r/42022/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/#review114945
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java (lines 132 - 135)
<https://reviews.apache.org/r/42022/#comment175770>
Can you add comments on whats happening here ?
- Amareshwari Sriramadasu
On Jan. 14, 2016, 6:09 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42022/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 6:09 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-912
> https://issues.apache.org/jira/browse/LENS-912
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
> lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
> lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
> lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
>
> Diff: https://reviews.apache.org/r/42022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 11:39 a.m.)
Review request for lens.
Bugs: LENS-912
https://issues.apache.org/jira/browse/LENS-912
Repository: lens
Description
-------
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 91cbe391a2bc81edae587b268104940122993243
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java dcb932e63d3419745c2b468845f3a4ec02e4552e
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b1deb0753fe36d2908ed4c8a98178a93644fab64
lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java 35de4d7ecdeb3575ea729fccab4da8824cef2344
lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
Diff: https://reviews.apache.org/r/42022/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 42022: LENS-912: Make `cube` keyword optional in
queries
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42022/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 4:36 p.m.)
Review request for lens.
Bugs: LENS-912
https://issues.apache.org/jira/browse/LENS-912
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java e7550ca2c8307cba086e848e8b476a670366f7a5
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java abec2b338e0da6b56934a02d16c48a6a7917845a
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c
Diff: https://reviews.apache.org/r/42022/diff/
Testing
-------
Thanks,
Rajat Khandelwal