You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by pk...@apache.org on 2022/01/11 02:36:25 UTC
[superset] branch master updated: fix: dashboard reload crash (#17992)
This is an automated email from the ASF dual-hosted git repository.
pkdotson pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 3d829fc fix: dashboard reload crash (#17992)
3d829fc is described below
commit 3d829fc3c838358dd8c798ecaeefd34c502edca0
Author: Phillip Kelley-Dotson <pk...@yahoo.com>
AuthorDate: Mon Jan 10 18:34:28 2022 -0800
fix: dashboard reload crash (#17992)
* fix dashboard reload
* add more strict case
---
superset-frontend/src/dashboard/components/DashboardGrid.jsx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/DashboardGrid.jsx b/superset-frontend/src/dashboard/components/DashboardGrid.jsx
index ad03859..f12ffcb 100644
--- a/superset-frontend/src/dashboard/components/DashboardGrid.jsx
+++ b/superset-frontend/src/dashboard/components/DashboardGrid.jsx
@@ -158,7 +158,7 @@ class DashboardGrid extends React.PureComponent {
</DragDroppable>
)}
- {gridComponent.children.map((id, index) => (
+ {gridComponent?.children?.map((id, index) => (
<DashboardComponent
key={id}
id={id}
@@ -176,7 +176,7 @@ class DashboardGrid extends React.PureComponent {
))}
{/* make the area below components droppable */}
- {editMode && gridComponent.children.length > 0 && (
+ {editMode && gridComponent?.children?.length > 0 && (
<DragDroppable
component={gridComponent}
depth={depth}