You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/03/14 11:11:07 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40409: [SPARK-42782][SQL][TESTS] Port the tests for get_json_object from the Apache Hive project

HyukjinKwon commented on code in PR #40409:
URL: https://github.com/apache/spark/pull/40409#discussion_r1135380192


##########
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala:
##########
@@ -81,6 +81,90 @@ class JsonFunctionsSuite extends QueryTest with SharedSparkSession {
       expected)
   }
 
+  test("SPARK-42782: Port get_json_object's tests from the Apache Hive project") {

Review Comment:
   Why don't you name this test title like "SPARK-42782: Hive compatibility check for get_json_object"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org