You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by vk...@apache.org on 2008/09/10 11:00:40 UTC

svn commit: r693743 - /portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/RoleChooserPortlet.java

Author: vkumar
Date: Wed Sep 10 02:00:39 2008
New Revision: 693743

URL: http://svn.apache.org/viewvc?rev=693743&view=rev
Log:
Optimizing RoleChooser portlet functionality with  new security API's

Modified:
    portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/RoleChooserPortlet.java

Modified: portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/RoleChooserPortlet.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/RoleChooserPortlet.java?rev=693743&r1=693742&r2=693743&view=diff
==============================================================================
--- portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/RoleChooserPortlet.java (original)
+++ portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/RoleChooserPortlet.java Wed Sep 10 02:00:39 2008
@@ -62,22 +62,11 @@
         List resultSetTypeList = new ArrayList();
         try
         {
-            Iterator roles = roleManager.getRoles("").iterator();
-                        
-            
             resultSetTypeList.add(String.valueOf(Types.VARCHAR));
             resultSetTitleList.add("Role");
 
-            // TODO: need to try to normalize List/Collection/Iterators
-            List list = new ArrayList();
-            while (roles.hasNext())
-            {
-                Role role = (Role)roles.next();
-                
-                //Principal principal = role.getPrincipal();                
-                //list.add(principal.getName());
-                list.add(role.getName());
-            }            
+            List<String> list = roleManager.getRoleNames("");
+            
             BrowserIterator iterator = new DatabaseBrowserIterator(
                     list, resultSetTitleList, resultSetTypeList,
                     windowSize);



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org