You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/30 01:29:01 UTC
[PR] fix(alert): reject null rules in imports [rocketmq-dashboard]
yyqdbngt opened a new pull request, #2821:
URL: https://github.com/apache/rocketmq-dashboard/pull/2821
## Summary
- require every element in an imported alert rule list to be non-null
- preserve nested bean validation for valid rule objects
- add DTO validation regression coverage
## Why
A list containing null satisfied the container constraints and could fail later while processing an otherwise accepted import request.
## Testing
- `JAVA_HOME=/opt/homebrew/opt/openjdk@21 PATH=/opt/homebrew/opt/openjdk@21/bin:$PATH mvn -f server/pom.xml -Dtest=AlertRuleTransferDTOTest test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): reject null rules in imports [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2821: fix(alert): reject null rules in imports
URL: https://github.com/apache/rocketmq-dashboard/pull/2821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): reject null rules in imports [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2821:
URL: https://github.com/apache/rocketmq-dashboard/pull/2821#issuecomment-5477606537
Merged into the #2802 consolidation batch (same author, alerting robustness fixes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org