You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/27 15:01:23 UTC
[GitHub] [incubator-gobblin] htran1 opened a new pull request #2941: [GOBBLIN-1100] Set average fetch time in the KafkaExtractor even when…
htran1 opened a new pull request #2941: [GOBBLIN-1100] Set average fetch time in the KafkaExtractor even when…
URL: https://github.com/apache/incubator-gobblin/pull/2941
… metrics are disabled
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1100
### Description
- [X] Here are some details about my PR, including screenshots (if applicable):
The KafkaExtractor close method only calls the KafkaExtractorStatsTracker#emitTrackingEvents method when metrics instrumentation is enabled. This method calls KafkaExtractorStatsTracker#generateTagsForPartitions, which has the side effect of setting the average fetch time in the WorkUnitState. The average fetch time is required for the work unit packing to pack optimally.
Add a call to KafkaExtractorStatsTracker#generateTagsForPartitions in KafkaExtractor#close when metrics instrumentation is disabled to restore the behavior that existed prior to the KafkaExtractorStatsTracker refactoring.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
KafkaExtractorStatsTrackerTest
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2941: [GOBBLIN-1100] Set average fetch time in the KafkaExtractor even when…
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #2941: [GOBBLIN-1100] Set average fetch time in the KafkaExtractor even when…
URL: https://github.com/apache/incubator-gobblin/pull/2941#discussion_r399392080
##########
File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractor.java
##########
@@ -321,6 +322,11 @@ public void close() throws IOException {
this.workUnitState.setActualHighWatermark(this.nextWatermark);
if (isInstrumentationEnabled()) {
this.statsTracker.emitTrackingEvents(getMetricContext(), this.lowWatermark, this.highWatermark, this.nextWatermark);
+ } else {
Review comment:
Should we move the isInstrumentationEnabled() check inside emitTrackingEventsWithAdditionalTags() and emit tracking events if it is true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2941: [GOBBLIN-1100] Set average fetch time in the KafkaExtractor even when…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2941: [GOBBLIN-1100] Set average fetch time in the KafkaExtractor even when…
URL: https://github.com/apache/incubator-gobblin/pull/2941
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #2941: [GOBBLIN-1100] Set average fetch time in the KafkaExtractor even when…
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #2941: [GOBBLIN-1100] Set average fetch time in the KafkaExtractor even when…
URL: https://github.com/apache/incubator-gobblin/pull/2941#discussion_r399459762
##########
File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractor.java
##########
@@ -321,6 +322,11 @@ public void close() throws IOException {
this.workUnitState.setActualHighWatermark(this.nextWatermark);
if (isInstrumentationEnabled()) {
this.statsTracker.emitTrackingEvents(getMetricContext(), this.lowWatermark, this.highWatermark, this.nextWatermark);
+ } else {
Review comment:
I moved the generateTagsForPartitions() call out so that emitTrackingEvents is only for emitting the events.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] htran1 commented on issue #2941: [GOBBLIN-1100] Set average fetch time in the KafkaExtractor even when…
Posted by GitBox <gi...@apache.org>.
htran1 commented on issue #2941: [GOBBLIN-1100] Set average fetch time in the KafkaExtractor even when…
URL: https://github.com/apache/incubator-gobblin/pull/2941#issuecomment-605048421
@autumnust, @sv2000, please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services