[GitHub] [james-project] vttranlina commented on a diff in pull request #1572: DeletedMessagesVault API - support limit query

["vttranlina (via GitHub)" <gi...@apache.org>]

vttranlina commented on code in PR #1572:
URL: https://github.com/apache/james-project/pull/1572#discussion_r1204951996


##########
mailbox/plugin/deleted-messages-vault/src/main/java/org/apache/james/vault/dto/query/QueryDTO.java:
##########
@@ -65,6 +67,13 @@ public List<QueryElement> getCriteria() {
         return criteria;
     }
 
+
+    @JsonGetter("limit")
+    public Long getLimitAsLong() {
+        return limit.orElse(null);
+    }
+
+    @JsonIgnore

Review Comment:
   Can you explain more? 
   
   `@JsonIgnore` just for ignoring the `Optional limit` 
   
   > Add the JDK 8 Jackson Module 
   
   Your mean is `new ObjectMapper().registerModule(new Jdk8Module());` ? , the `QueryElementSerializer` already receives the `ObjectMapper` bean in constructors, I don't think we should modify the bean



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org