You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by df...@apache.org on 2009/02/11 11:35:04 UTC
svn commit: r743292 -
/commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/BasicRowProcessor.java
Author: dfabulich
Date: Wed Feb 11 10:35:04 2009
New Revision: 743292
URL: http://svn.apache.org/viewvc?rev=743292&view=rev
Log:
Incorporating a couple more of Julien's suggestions (especially to use an entrySet instead of a keySet0
Modified:
commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/BasicRowProcessor.java
Modified: commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/BasicRowProcessor.java
URL: http://svn.apache.org/viewvc/commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/BasicRowProcessor.java?rev=743292&r1=743291&r2=743292&view=diff
==============================================================================
--- commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/BasicRowProcessor.java (original)
+++ commons/sandbox/dbutils/bugfixing/src/java/org/apache/commons/dbutils/BasicRowProcessor.java Wed Feb 11 10:35:04 2009
@@ -171,7 +171,7 @@
* </ul>
* </p>
*/
- private Map lowerCaseMap = new HashMap();
+ private final Map lowerCaseMap = new HashMap();
/**
* Required for serialization support.
@@ -221,10 +221,11 @@
* @see java.util.Map#putAll(java.util.Map)
*/
public void putAll(Map m) {
- Iterator iter = m.keySet().iterator();
+ Iterator iter = m.entrySet().iterator();
while (iter.hasNext()) {
- Object key = iter.next();
- Object value = m.get(key);
+ Map.Entry entry = (Map.Entry) iter.next();
+ Object key = entry.getKey();
+ Object value = entry.getValue();
this.put(key, value);
}
}