[GitHub] [beam] kw2542 commented on a change in pull request #15322: [BEAM-12742] Samza Runner does not properly delete modified timer

[GitBox <gi...@apache.org>]

kw2542 commented on a change in pull request #15322:
URL: https://github.com/apache/beam/pull/15322#discussion_r687994742



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -4670,7 +4670,7 @@ public void onTimer(
     }
 
     @Test
-    @Category(NeedsRunner.class)
+    @Category({NeedsRunner.class, UsesTimersInParDo.class, UsesTestStream.class})

Review comment:
       Good point, this is what I would like to understand the common practice in beam.
   
   `UsesTestStreamWithProcessingTime` is a subtype of `UsesTestStream`, based on JUnit documentation, tests marked as `UsesTestStreamWithProcessingTime` is also part of `UsesTestStream` but not the other way around.
   
   Therefore, if a test is marked as `UsesTestStreamWithProcessingTime`, then marking it with `UsesTestStream` does not effectively change how it behaves since it transiently belongs to `UsesTestStream` category as well.
   
   However, I do agree that having both annotations here are clearer and more readable and there does not seem to have cons to have both annotations.
   
   What are your suggestions here?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org