You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/06 05:07:55 UTC
[GitHub] [apisix] tzssangglass opened a new pull request #5434: fix(admin): modify boolean parameters with PATCH
tzssangglass opened a new pull request #5434:
URL: https://github.com/apache/apisix/pull/5434
Closes #5430
Signed-off-by: tzssangglass <tz...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5434: fix(admin): modify boolean parameters with PATCH
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #5434:
URL: https://github.com/apache/apisix/pull/5434#discussion_r744355443
##########
File path: t/admin/routes3.t
##########
@@ -700,3 +700,103 @@ passed
}
--- response_body
passed
+
+
+
+=== TEST 20: set route(id: 1, parameters with boolean values)
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+ "uri": "/index.html",
+ "enable_websocket": true,
+ "upstream": {
+ "type": "roundrobin",
+ "nodes": {
+ "127.0.0.1:8080":1
+ }
+ }
+ }]],
+ [[{
+ "node": {
Review comment:
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5434: fix(admin): modify boolean parameters with PATCH
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5434:
URL: https://github.com/apache/apisix/pull/5434#discussion_r744345047
##########
File path: t/admin/routes3.t
##########
@@ -700,3 +700,103 @@ passed
}
--- response_body
passed
+
+
+
+=== TEST 20: set route(id: 1, parameters with boolean values)
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+ "uri": "/index.html",
+ "enable_websocket": true,
+ "upstream": {
+ "type": "roundrobin",
+ "nodes": {
+ "127.0.0.1:8080":1
+ }
+ }
+ }]],
+ [[{
+ "node": {
Review comment:
This test is only for setting up route 1, we don't need to check the raw response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5434: fix(admin): modify boolean parameters with PATCH
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5434:
URL: https://github.com/apache/apisix/pull/5434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org