You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/05/16 21:21:32 UTC
[kudu-CR] KUDU-2427: update to latest version of curl
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10432
to review the following change.
Change subject: KUDU-2427: update to latest version of curl
......................................................................
KUDU-2427: update to latest version of curl
The existing version of curl doesn't work with OpenSSL 1.1, which is what
ships by default with Ubuntu 18.04.
Without the change to curl_util.cc, SslWebserverTest_TestSSL fails with:
curl error: SSL peer certificate or SSH remote key was not OK
Change-Id: I804d01a5ed702501223dd4099100153cca412b49
---
M src/kudu/util/curl_util.cc
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
3 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/10432/1
--
To view, visit http://gerrit.cloudera.org:8080/10432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I804d01a5ed702501223dd4099100153cca412b49
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2427: update to latest version of curl
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10432 )
Change subject: KUDU-2427: update to latest version of curl
......................................................................
KUDU-2427: update to latest version of curl
The existing version of curl doesn't work with OpenSSL 1.1, which is what
ships by default with Ubuntu 18.04.
Without the change to curl_util.cc, SslWebserverTest_TestSSL fails with:
curl error: SSL peer certificate or SSH remote key was not OK
Change-Id: I804d01a5ed702501223dd4099100153cca412b49
Reviewed-on: http://gerrit.cloudera.org:8080/10432
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/curl_util.cc
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
3 files changed, 9 insertions(+), 5 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I804d01a5ed702501223dd4099100153cca412b49
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2427: update to latest version of curl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10432 )
Change subject: KUDU-2427: update to latest version of curl
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804d01a5ed702501223dd4099100153cca412b49
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 16 May 2018 21:42:08 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2427: update to latest version of curl
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10432 )
Change subject: KUDU-2427: update to latest version of curl
......................................................................
Patch Set 2: Code-Review+2
Carrying forward Alexey's +2.
--
To view, visit http://gerrit.cloudera.org:8080/10432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804d01a5ed702501223dd4099100153cca412b49
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 17 May 2018 03:22:17 +0000
Gerrit-HasComments: No