[GitHub] [arrow-rs] viirya commented on a diff in pull request #3718: Deprecate old JSON reader (#3610)

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #3718:
URL: https://github.com/apache/arrow-rs/pull/3718#discussion_r1106078927


##########
arrow-json/src/reader.rs:
##########
@@ -582,6 +582,7 @@ where
 /// [`RawDecoder`]: crate::raw::RawDecoder
 /// [#3610]: https://github.com/apache/arrow-rs/issues/3610
 #[derive(Debug)]
+#[deprecated(note = "Use RawDecoder instead")]

Review Comment:
   Still need the comment? Actually it reads unclear and seems strange to put issue link there.
   
   ```suggestion
   #[derive(Debug)]
   #[deprecated(note = "Use RawDecoder instead")]
   ```



##########
arrow-json/src/reader.rs:
##########
@@ -1604,12 +1606,15 @@ fn flatten_json_string_values(values: &[Value]) -> Vec<Option<String>> {
 /// [`RawReader`]: crate::raw::RawReader
 /// [#3610]: https://github.com/apache/arrow-rs/issues/3610

Review Comment:
   ditto.
   
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org