You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by du...@apache.org on 2023/03/20 05:49:24 UTC
[shardingsphere] branch master updated: Rename HBaseCheckerFactoryTest (#24683)
This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 50d4f6dff33 Rename HBaseCheckerFactoryTest (#24683)
50d4f6dff33 is described below
commit 50d4f6dff33e330a34d38e96246aacd78c0901ac
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Mon Mar 20 13:49:17 2023 +0800
Rename HBaseCheckerFactoryTest (#24683)
* Upgrade junit 5 on HBase checker test
* Rename HBaseCheckerFactoryTest
---
.../backend/hbase/checker/HBaseCheckerFactory.java | 18 ++++++++++--------
...erFactoryTest.java => HBaseCheckerFactoryTest.java} | 2 +-
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/proxy/backend/type/hbase/src/main/java/org/apache/shardingsphere/proxy/backend/hbase/checker/HBaseCheckerFactory.java b/proxy/backend/type/hbase/src/main/java/org/apache/shardingsphere/proxy/backend/hbase/checker/HBaseCheckerFactory.java
index 0a295e63e5f..4f4b84d5dec 100644
--- a/proxy/backend/type/hbase/src/main/java/org/apache/shardingsphere/proxy/backend/hbase/checker/HBaseCheckerFactory.java
+++ b/proxy/backend/type/hbase/src/main/java/org/apache/shardingsphere/proxy/backend/hbase/checker/HBaseCheckerFactory.java
@@ -32,22 +32,24 @@ import org.apache.shardingsphere.sql.parser.sql.common.statement.dml.UpdateState
public final class HBaseCheckerFactory {
/**
- * Create new instance of heterogeneous database checker.
+ * Create new instance of HBase checker.
*
- * @param sqlStatement sql statement
- * @return instance of database backend handler
+ * @param sqlStatement SQL statement
+ * @return created instance
*/
public static HeterogeneousSQLStatementChecker<?> newInstance(final SQLStatement sqlStatement) {
if (sqlStatement instanceof SelectStatement) {
return new HeterogeneousSelectStatementChecker((SelectStatement) sqlStatement);
- } else if (sqlStatement instanceof InsertStatement) {
+ }
+ if (sqlStatement instanceof InsertStatement) {
return new HeterogeneousInsertStatementChecker((InsertStatement) sqlStatement);
- } else if (sqlStatement instanceof DeleteStatement) {
+ }
+ if (sqlStatement instanceof DeleteStatement) {
return new HeterogeneousDeleteStatementChecker((DeleteStatement) sqlStatement);
- } else if (sqlStatement instanceof UpdateStatement) {
+ }
+ if (sqlStatement instanceof UpdateStatement) {
return new HeterogeneousUpdateStatementChecker((UpdateStatement) sqlStatement);
- } else {
- return new CommonHeterogeneousSQLStatementChecker<>(sqlStatement);
}
+ return new CommonHeterogeneousSQLStatementChecker<>(sqlStatement);
}
}
diff --git a/proxy/backend/type/hbase/src/test/java/org/apache/shardingsphere/proxy/backend/hbase/checker/HBaseDatabaseCheckerFactoryTest.java b/proxy/backend/type/hbase/src/test/java/org/apache/shardingsphere/proxy/backend/hbase/checker/HBaseCheckerFactoryTest.java
similarity index 98%
rename from proxy/backend/type/hbase/src/test/java/org/apache/shardingsphere/proxy/backend/hbase/checker/HBaseDatabaseCheckerFactoryTest.java
rename to proxy/backend/type/hbase/src/test/java/org/apache/shardingsphere/proxy/backend/hbase/checker/HBaseCheckerFactoryTest.java
index 0248c871c7c..b55951f375a 100644
--- a/proxy/backend/type/hbase/src/test/java/org/apache/shardingsphere/proxy/backend/hbase/checker/HBaseDatabaseCheckerFactoryTest.java
+++ b/proxy/backend/type/hbase/src/test/java/org/apache/shardingsphere/proxy/backend/hbase/checker/HBaseCheckerFactoryTest.java
@@ -30,7 +30,7 @@ import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.mockito.Mockito.mock;
-public final class HBaseDatabaseCheckerFactoryTest {
+public final class HBaseCheckerFactoryTest {
@Test
public void assertExecuteSelectStatement() {