[GitHub] [spark] cloud-fan commented on a change in pull request #34753: [SPARK-37494][SQL] Unify v1 and v2 options output of `SHOW CREATE TABLE` command

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34753:
URL: https://github.com/apache/spark/pull/34753#discussion_r759921072



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ShowCreateTableSuite.scala
##########
@@ -200,6 +200,28 @@ abstract class ShowCreateTableSuite extends QueryTest with SQLTestUtils {
     }
   }
 
+  test("SPARK-37494: Unify v1 and v2 option output") {
+    withTable("ddl_test") {
+      sql(
+        s"""CREATE TABLE ddl_test (
+           |  a STRING
+           |)
+           |USING json
+           |OPTIONS (
+           | 'k1' = 'v1',
+           | k2 = 'v2',
+           | `k3` 'v3',
+           | k4 'v4',
+           | 'k5' 'v5'

Review comment:
       can we test `TBLPROPERTIES` as well since you fixed it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org