You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by yatsukhnenko <gi...@git.apache.org> on 2016/05/04 14:04:20 UTC
[GitHub] trafficserver pull request: Add new limit rate example plugin
GitHub user yatsukhnenko opened a pull request:
https://github.com/apache/trafficserver/pull/615
Add new limit rate example plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yatsukhnenko/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/615.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #615
----
commit da79ad3f1de51d49e1cb811313961dc700ed5a81
Author: Pavlo Yatsukhnenko <ya...@gmail.com>
Date: 2016-05-04T13:58:21Z
Add new limit rate example plugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Add new limit rate example plugin
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-218788246
Not sure why you couldn't create the Jira, but I made one for you: https://issues.apache.org/jira/browse/TS-4437. All you should have to do is to register with the Jira instance, and anyone can create Jira's against ATS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Add new limit rate example plugin
Posted by yatsukhnenko <gi...@git.apache.org>.
Github user yatsukhnenko commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-218266124
1) done
2) I used vconn and timer to control a portioning of data. What do you think about that? Maybe it should be done on the "lower" level or maybe we should use different algorithm?
What else we need to turn this in real plugin? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4437] Add new limit rate example p...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-219190139
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Add new limit rate example plugin
Posted by yatsukhnenko <gi...@git.apache.org>.
Github user yatsukhnenko commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-218671191
There is no Jira for this PR and I can't create new issue :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4437] Add new limit rate example p...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-219191866
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4437] Add new limit rate example p...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-219194915
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4437] Add new limit rate example p...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-219186490
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Add new limit rate example plugin
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-218782568
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4437] Add new limit rate example p...
Posted by yatsukhnenko <gi...@git.apache.org>.
Github user yatsukhnenko closed the pull request at:
https://github.com/apache/trafficserver/pull/615
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Add new limit rate example plugin
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-217455283
Taking a quick look, two comments:
1) You must add the AL2 license blurb to all new files.
2) As is, this does belong as an example. I'm wondering / hoping that we'd eventually turn this into a real plugin?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Add new limit rate example plugin
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-218525606
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Add new limit rate example plugin
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/615#issuecomment-218620870
Also, would you mind adding the Jira number to the Subject line to this commit / PR? It helps us associate the PR with the correct Jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---