You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Daniel Templeton (JIRA)" <ji...@apache.org> on 2016/03/23 17:27:25 UTC
[jira] [Commented] (MAPREDUCE-6575) TestMRJobs.setup() should use
YarnConfiguration properties instead of bare strings
[ https://issues.apache.org/jira/browse/MAPREDUCE-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208706#comment-15208706 ]
Daniel Templeton commented on MAPREDUCE-6575:
---------------------------------------------
I just did a regex search through the code, and these bare string properties appear all over the place. There are a ridiculous number in the test classes, but still a good number in the product code. When I sit down to this one, I'll see if I have the stomach to take on all the product code cases.
> TestMRJobs.setup() should use YarnConfiguration properties instead of bare strings
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6575
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6575
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
>
> MAPREDUCE-5870 introduced the following line:
> {code}
> conf.setInt("yarn.cluster.max-application-priority", 10);
> {code}
> It should instead be:
> {code}
> conf.setInt(YarnConfiguration.MAX_CLUSTER_LEVEL_APPLICATION_PRIORITY, 10);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)