[GitHub] [incubator-superset] gaurav1999 commented on issue #9166: Make possible to render all the tabs at once on dom, not when you click on each tab.

[GitBox <gi...@apache.org>]

gaurav1999 commented on issue #9166: Make possible to render all the tabs at once on dom, not when you click on each tab.
URL: https://github.com/apache/incubator-superset/issues/9166#issuecomment-593803452
 
 
   Hi @willbarrett , 
   Yes the explanation is on point, I also tried to research this out on my own and figured out this is because of performance and database requests because of which it has been designed this way at the moment. However I was not aware of details this deep. Thanks for that.
   
   So, my use case was to print dashboards, and yes I explored a lots of ideas, first one was to get screenshot of dashboard using things like html2canvas and js2pdf but that did not worked out because not all the tabs were here in the DOM and I wish to capture all of them at once.
   
   Also, with html2canvas and js2pdf quality of PDF's are not that great because of color models and svg charts :-/
   
   So, to enusre quality and make sure all the tabs could be rendered in single pdf I went with headless browser tool. You are correct on this too. Yes of-course it's really really slow but if it works and there is no other way at the moment, I guess we have to stick with it.
   
   
   It's been a long time, now that I have figured things already and proceeded I guess this issue is resolved for my use case, and whatever I learnt on my own now I have a validation of that learning in form of this discussion as well :-) ! 
   
   However, I am not sure we want to close this issue or not, because in my opinion even if this is not about my use case of printing dashboards, but it totally makes sense that this approach can be rethought of and there are certainly scope of optimizations over here.
   
   So I will leave that thought on maintainers.
   
   Thanks!
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org