You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/12/26 14:34:23 UTC
[GitHub] [incubator-doris] imay commented on a change in pull request #2570:
Fix bitmap, hll, segment v2 DefaultValue bug
imay commented on a change in pull request #2570: Fix bitmap, hll, segment v2 DefaultValue bug
URL: https://github.com/apache/incubator-doris/pull/2570#discussion_r361467304
##########
File path: be/src/olap/rowset/segment_v2/column_reader.h
##########
@@ -305,9 +307,12 @@ class DefaultValueColumnIterator : public ColumnIterator {
std::string _default_value;
bool _is_nullable;
FieldType _type;
+ size_t _length;
Review comment:
pls add some comments for length and value_size. This may cause people confused
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org