You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 20:44:27 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #27923: Mask audit log extra field

ashb commented on code in PR #27923:
URL: https://github.com/apache/airflow/pull/27923#discussion_r1032681194


##########
airflow/www/decorators.py:
##########
@@ -56,6 +57,7 @@ def wrapper(*args, **kwargs):
                     for k, v in chain(request.values.items(multi=True), request.view_args.items())
                     if k not in fields_skip_logging
                 ]
+                extra_fields = [(k, secrets_masker.redact(v, k)) for k, v in extra_fields]

Review Comment:
   Why not redact "in place" as we build up (on line 55/56)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org