[GitHub] mistercrunch commented on a change in pull request #5395: Fix/heatmap null value render error

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5395: Fix/heatmap null value render error
URL: https://github.com/apache/incubator-superset/pull/5395#discussion_r202887243
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -1901,6 +1901,7 @@ def get_data(self, df):
         if overall:
             df['perc'] = (df.v - min_) / (max_ - min_)
             df['rank'] = df.v.rank(pct=True)
+        df[['x', 'y']] = df[['x', 'y']].fillna('Null')
 
 Review comment:
   Can we use `<NULL>` to align with other places in the code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org