You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ba...@apache.org on 2011/06/04 04:44:27 UTC

svn commit: r1131309 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FormatCache.java

Author: bayard
Date: Sat Jun  4 02:44:27 2011
New Revision: 1131309

URL: http://svn.apache.org/viewvc?rev=1131309&view=rev
Log:
Adding comment on refactoring of API before making it public

Modified:
    commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FormatCache.java

Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FormatCache.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FormatCache.java?rev=1131309&r1=1131308&r2=1131309&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FormatCache.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FormatCache.java Sat Jun  4 02:44:27 2011
@@ -31,6 +31,7 @@ import java.util.concurrent.ConcurrentMa
  * @since 3.0
  * @version $Id: FormatCache 892161 2009-12-18 07:21:10Z  $
  */
+// TODO: Before making public move from getDateTimeInstance(Integer,...) to int; or some other approach.
 abstract class FormatCache<F extends Format> {
     /**
      * No date or no time.  Used in same parameters as DateFormat.SHORT or DateFormat.LONG
@@ -115,7 +116,7 @@ abstract class FormatCache<F extends For
      * @throws IllegalArgumentException if the Locale has no date/time
      *  pattern defined
      */
-    public F getDateTimeInstance(Integer dateStyle, Integer timeStyle, TimeZone timeZone, Locale locale) {
+    public F getDateTimeInstance(int dateStyle, int timeStyle, TimeZone timeZone, Locale locale) {
         if (locale == null) {
             locale = Locale.getDefault();
         }