You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "josh-fell (via GitHub)" <gi...@apache.org> on 2023/02/28 18:25:29 UTC

[GitHub] [airflow] josh-fell opened a new pull request, #29816: Move ref anchor for env var link in Connection how-to doc

josh-fell opened a new pull request, #29816:
URL: https://github.com/apache/airflow/pull/29816

   In the "Managing Connections" how-to doc, the "environment variables" links in the doc point to the "Security of connections in the database" section rather than the "Storing connections in environment variables" section.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] josh-fell commented on a diff in pull request #29816: Move ref anchor for env var link in Connection how-to doc

Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on code in PR #29816:
URL: https://github.com/apache/airflow/pull/29816#discussion_r1120779955


##########
docs/apache-airflow-providers-dbt-cloud/connections.rst:
##########
@@ -102,5 +102,5 @@ For example, to add a connection with the connection ID of "dbt_cloud_default":
         export AIRFLOW_CONN_DBT_CLOUD_DEFAULT='dbt-cloud://:api_token@my-tenant.getdbt.com'
 
 You can refer to the documentation on
-:ref:`creating connections via environment variables <environment_variables_secrets_backend>` for more
+:ref:`creating connections via environment variables <environment_variables_connections>` for more

Review Comment:
   The same reference anchor was used in the dbt Cloud connection docs too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a diff in pull request #29816: Move ref anchor for env var link in Connection how-to doc

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29816:
URL: https://github.com/apache/airflow/pull/29816#discussion_r1120705412


##########
docs/apache-airflow/howto/connection.rst:
##########
@@ -31,6 +31,8 @@ Connections may be defined in the following ways:
   - in the :ref:`Airflow metadata database <connections-in-database>`
     (using the :ref:`CLI <connection/cli>` or :ref:`web UI <creating_connection_ui>`)
 
+.. _environment_variables_secrets_backend:

Review Comment:
   ```suggestion
   .. _environment_variables_connections:
   ```
   
   Maybe?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] josh-fell commented on pull request #29816: Fix ref anchor for env var link in Connection how-to doc

Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on PR #29816:
URL: https://github.com/apache/airflow/pull/29816#issuecomment-1452215030

   @eladkal Should hold off on the merging this for now since the dbt Cloud connection doc is involved here and the next provider wave is in progress? Or it's fine and the dbt Cloud change will just be part of the next wave?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] josh-fell commented on a diff in pull request #29816: Move ref anchor for env var link in Connection how-to doc

Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on code in PR #29816:
URL: https://github.com/apache/airflow/pull/29816#discussion_r1120710255


##########
docs/apache-airflow/howto/connection.rst:
##########
@@ -31,6 +31,8 @@ Connections may be defined in the following ways:
   - in the :ref:`Airflow metadata database <connections-in-database>`
     (using the :ref:`CLI <connection/cli>` or :ref:`web UI <creating_connection_ui>`)
 
+.. _environment_variables_secrets_backend:

Review Comment:
   Oh, rename it? That's a better name for sure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on pull request #29816: Fix ref anchor for env var link in Connection how-to doc

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #29816:
URL: https://github.com/apache/airflow/pull/29816#issuecomment-1452234223

   Also, probably we should start look into the cross references of providers -> core. Ideally providers docs should be stand alone. They should not use internal references because we want to treat providers as stand alone packages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on pull request #29816: Fix ref anchor for env var link in Connection how-to doc

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #29816:
URL: https://github.com/apache/airflow/pull/29816#issuecomment-1452230814

   We can merge but I guess since releases are not synced there will be some time that the reference won't work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] josh-fell commented on pull request #29816: Fix ref anchor for env var link in Connection how-to doc

Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on PR #29816:
URL: https://github.com/apache/airflow/pull/29816#issuecomment-1452306725

   > We can merge but I guess since releases are not synced there will be some time that the reference won't work
   
   I think that's fine. It's the only provider that uses this link and there are a few examples of creating the connection with env vars too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a diff in pull request #29816: Move ref anchor for env var link in Connection how-to doc

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29816:
URL: https://github.com/apache/airflow/pull/29816#discussion_r1120721896


##########
docs/apache-airflow/howto/connection.rst:
##########
@@ -31,6 +31,8 @@ Connections may be defined in the following ways:
   - in the :ref:`Airflow metadata database <connections-in-database>`
     (using the :ref:`CLI <connection/cli>` or :ref:`web UI <creating_connection_ui>`)
 
+.. _environment_variables_secrets_backend:

Review Comment:
   Yep



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] josh-fell merged pull request #29816: Fix ref anchor for env var link in Connection how-to doc

Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell merged PR #29816:
URL: https://github.com/apache/airflow/pull/29816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org