You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/24 23:07:20 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #10157: refactor: import emotion-theming methods from @superset-ui/style
ktmud opened a new pull request #10157:
URL: https://github.com/apache/incubator-superset/pull/10157
### SUMMARY
This makes the code cleaner and fixes missing theme variables when `npm link @superset-ui/style`.
Webpack somehow have independent namespaces for regular JS modules and those in soft-linked `node_modules`, so `import { styled } from '@superset-ui/style'` and `import { ThemeProvider } from 'emotion-theming' will access different cached themes.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
Manual testing, expect styled components used `theme` variables correctly load when `npm link ~/projects/superset-ui/packages/superset-ui-style` and `npm run dev`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10157: refactor: import emotion-theming methods from @superset-ui/style
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10157:
URL: https://github.com/apache/incubator-superset/pull/10157#issuecomment-649121291
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=h1) Report
> Merging [#10157](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a794ed68418d76eaf48187c010d05cae89b7e56&el=desc) will **decrease** coverage by `4.63%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10157 +/- ##
==========================================
- Coverage 70.50% 65.86% -4.64%
==========================================
Files 594 594
Lines 31391 31388 -3
Branches 3215 3215
==========================================
- Hits 22131 20673 -1458
- Misses 9144 10534 +1390
- Partials 116 181 +65
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.64% <50.00%> (+<0.01%)` | :arrow_up: |
| #python | `70.29% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `71.87% <100.00%> (-0.44%)` | :arrow_down: |
| ... and [145 more](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=footer). Last update [7a794ed...52eba38](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10157: refactor: import emotion-theming methods from @superset-ui/style
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10157:
URL: https://github.com/apache/incubator-superset/pull/10157#issuecomment-649121291
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=h1) Report
> Merging [#10157](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a794ed68418d76eaf48187c010d05cae89b7e56&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10157 +/- ##
==========================================
- Coverage 70.50% 70.41% -0.09%
==========================================
Files 594 594
Lines 31391 31389 -2
Branches 3215 3215
==========================================
- Hits 22131 22102 -29
- Misses 9144 9170 +26
- Partials 116 117 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.99% <ø> (-0.51%)` | :arrow_down: |
| #javascript | `59.64% <50.00%> (+<0.01%)` | :arrow_up: |
| #python | `70.29% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `71.87% <100.00%> (-0.44%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=footer). Last update [7a794ed...52eba38](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed pull request #10157: refactor: import emotion-theming methods from @superset-ui/style
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #10157:
URL: https://github.com/apache/incubator-superset/pull/10157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10157: refactor: import emotion-theming methods from @superset-ui/style
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10157:
URL: https://github.com/apache/incubator-superset/pull/10157#issuecomment-649121291
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=h1) Report
> Merging [#10157](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/36ea42f09245b101b04bfaf55a17e19fae6d15fc&el=desc) will **decrease** coverage by `0.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10157 +/- ##
==========================================
- Coverage 70.48% 70.06% -0.43%
==========================================
Files 594 190 -404
Lines 31388 18308 -13080
Branches 3215 0 -3215
==========================================
- Hits 22124 12827 -9297
+ Misses 9148 5481 -3667
+ Partials 116 0 -116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.06% <ø> (-0.23%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.28% <0.00%> (-2.29%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.00% <0.00%> (-0.96%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.47% <0.00%> (-0.30%)` | :arrow_down: |
| ... and [401 more](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=footer). Last update [36ea42f...9c4092b](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10157: refactor: import emotion-theming methods from @superset-ui/style
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10157:
URL: https://github.com/apache/incubator-superset/pull/10157#issuecomment-649141128
@lilykuang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10157: refactor: import emotion-theming methods from @superset-ui/style
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10157:
URL: https://github.com/apache/incubator-superset/pull/10157#issuecomment-649121291
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=h1) Report
> Merging [#10157](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a794ed68418d76eaf48187c010d05cae89b7e56&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10157 +/- ##
=======================================
Coverage 70.50% 70.50%
=======================================
Files 594 594
Lines 31391 31389 -2
Branches 3215 3215
=======================================
- Hits 22131 22130 -1
+ Misses 9144 9143 -1
Partials 116 116
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.48% <ø> (-0.01%)` | :arrow_down: |
| #javascript | `59.64% <50.00%> (+<0.01%)` | :arrow_up: |
| #python | `70.29% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `77.77% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `71.87% <100.00%> (-0.44%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10157/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `69.04% <0.00%> (+0.79%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=footer). Last update [7a794ed...52eba38](https://codecov.io/gh/apache/incubator-superset/pull/10157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #10157: refactor: import emotion-theming methods from @superset-ui/style
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #10157:
URL: https://github.com/apache/incubator-superset/pull/10157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org