[jira] [Comment Edited] (YETUS-643) default custom maven repo should use workspace when in jenkins mode

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565169#comment-16565169 ] 

Allen Wittenauer edited comment on YETUS-643 at 8/1/18 11:37 AM:
-----------------------------------------------------------------

There is a neat little edge case here in the current patches, that sort of goes back to the discussion in YETUS-435:  If maven is selected as the build tool but not actually put into the plugin field, then maven_initialize fires off and causes an exit.

We really need to have a larger discussion in the community about how when to forcibly enable plugins.  In this particular instance, forcing the build tool to always be enabled.

In the meantime, here's -002, which adds another spot where the replacer gets called in maven_initialize


was (Author: aw):
There is a neat little edge case here in the current patches, that sort of goes back to the discussion in YETUS-435:  If maven is selected as the build tool but not actually put into the plugin field, then maven_precheck fires off and causes an exit.

We really need to have a larger discussion in the community about how when to forcibly enable plugins.  In this particular instance, forcing the build tool to always be enabled.

In the meantime, here's -002, which adds another spot where the replacer gets called in maven_initialize

> default custom maven repo should use workspace when in jenkins mode
> -------------------------------------------------------------------
>
>                 Key: YETUS-643
>                 URL: https://issues.apache.org/jira/browse/YETUS-643
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Critical
>             Fix For: 0.8.0
>
>         Attachments: YETUS-643.00.patch, YETUS-643.001.patch, YETUS-643.002.patch
>
>
> Instead of using something off of home, maybe it would make more sense to use the workspace directory as the maven repo cache location when custom maven repos are used under Jenkins.  This would give a lot more exposure to what is going on that normally isn't seen.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)