You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2012/06/05 19:52:26 UTC
[jira] [Created] (MAPREDUCE-4318) TestRecoveryManagershould not use
raw and deprecated configuration parameters.
Konstantin Shvachko created MAPREDUCE-4318:
----------------------------------------------
Summary: TestRecoveryManagershould not use raw and deprecated configuration parameters.
Key: MAPREDUCE-4318
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4318
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: test
Affects Versions: 0.22.1
Reporter: Konstantin Shvachko
Assignee: Benoy Antony
TestRecoveryManager should not use deprecated config keys, and should use constants for the keys where possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MAPREDUCE-4318) TestRecoveryManager should not
use raw and deprecated configuration parameters.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko resolved MAPREDUCE-4318.
--------------------------------------------
Resolution: Fixed
Fix Version/s: 0.22.1
Hadoop Flags: Reviewed
I just committed this. Thank you Benoy.
> TestRecoveryManager should not use raw and deprecated configuration parameters.
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4318
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4318
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.1
> Reporter: Konstantin Shvachko
> Assignee: Benoy Antony
> Fix For: 0.22.1
>
> Attachments: MAPREDUCE-4318.patch
>
>
> TestRecoveryManager should not use deprecated config keys, and should use constants for the keys where possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4318) TestRecoveryManager should not
use raw and deprecated configuration parameters.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated MAPREDUCE-4318:
-------------------------------------------
Summary: TestRecoveryManager should not use raw and deprecated configuration parameters. (was: TestRecoveryManagershould not use raw and deprecated configuration parameters.)
+1 Looks good to me.
> TestRecoveryManager should not use raw and deprecated configuration parameters.
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4318
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4318
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.1
> Reporter: Konstantin Shvachko
> Assignee: Benoy Antony
> Attachments: MAPREDUCE-4318.patch
>
>
> TestRecoveryManager should not use deprecated config keys, and should use constants for the keys where possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (MAPREDUCE-4318) TestRecoveryManagershould
not use raw and deprecated configuration parameters.
Posted by "Benoy Antony (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MAPREDUCE-4318 started by Benoy Antony.
> TestRecoveryManagershould not use raw and deprecated configuration parameters.
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4318
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4318
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.1
> Reporter: Konstantin Shvachko
> Assignee: Benoy Antony
>
> TestRecoveryManager should not use deprecated config keys, and should use constants for the keys where possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4318) TestRecoveryManagershould not
use raw and deprecated configuration parameters.
Posted by "Benoy Antony (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290847#comment-13290847 ]
Benoy Antony commented on MAPREDUCE-4318:
-----------------------------------------
The other option will be to define the new way fo defining the queue configuration. This is followed in some other tests. I'll try that and attach a new patch
> TestRecoveryManagershould not use raw and deprecated configuration parameters.
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4318
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4318
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.1
> Reporter: Konstantin Shvachko
> Assignee: Benoy Antony
> Attachments: MAPREDUCE-4318.patch
>
>
> TestRecoveryManager should not use deprecated config keys, and should use constants for the keys where possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4318) TestRecoveryManagershould not use
raw and deprecated configuration parameters.
Posted by "Benoy Antony (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoy Antony updated MAPREDUCE-4318:
------------------------------------
Attachment: MAPREDUCE-4318.patch
Fixed the hardcoded keys.
Still need to use deprecated config key for mapred.queue.names
> TestRecoveryManagershould not use raw and deprecated configuration parameters.
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4318
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4318
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.1
> Reporter: Konstantin Shvachko
> Assignee: Benoy Antony
> Attachments: MAPREDUCE-4318.patch
>
>
> TestRecoveryManager should not use deprecated config keys, and should use constants for the keys where possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4318) TestRecoveryManagershould not
use raw and deprecated configuration parameters.
Posted by "Benoy Antony (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291203#comment-13291203 ]
Benoy Antony commented on MAPREDUCE-4318:
-----------------------------------------
Th other option was to use the new scheme of specifying mapred-queues.xml containing he queue configuration. I used QueueManagerTestUtils class to achieve this. But there are other mapred-queues.xml in the classpath which gets picked up before test's mapred-queues.xml with different configuration.
These files seem to be created when I build using eclipse and if I remove those mapred-queues.xml, then test passes. So this may be an eclipse created problem.
The old scheme of defining queues does not use mapred-queues.xml and hence will work regardless multiple mapred-queues.xml issues.
Since we are not testing Queue management here, I believe, keeping the following line makes the test more reliable.
mr.getJobTrackerConf().set(DeprecatedQueueConfigurationParser.MAPRED_QUEUE_NAMES_KEY,
"default");
So I recommend to go with the attached patch. Please let me know if there are some other ideas.
> TestRecoveryManagershould not use raw and deprecated configuration parameters.
> ------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4318
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4318
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.1
> Reporter: Konstantin Shvachko
> Assignee: Benoy Antony
> Attachments: MAPREDUCE-4318.patch
>
>
> TestRecoveryManager should not use deprecated config keys, and should use constants for the keys where possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4318) TestRecoveryManager should not
use raw and deprecated configuration parameters.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291550#comment-13291550 ]
Hudson commented on MAPREDUCE-4318:
-----------------------------------
Integrated in Hadoop-Mapreduce-22-branch #105 (See [https://builds.apache.org/job/Hadoop-Mapreduce-22-branch/105/])
MAPREDUCE-4318. TestRecoveryManager should not use raw configuration keys. Contributed by Benoy Antony. (Revision 1347853)
Result = FAILURE
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1347853
Files :
* /hadoop/common/branches/branch-0.22/mapreduce/CHANGES.txt
* /hadoop/common/branches/branch-0.22/mapreduce/src/test/mapred/org/apache/hadoop/mapred/TestRecoveryManager.java
> TestRecoveryManager should not use raw and deprecated configuration parameters.
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4318
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4318
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.1
> Reporter: Konstantin Shvachko
> Assignee: Benoy Antony
> Fix For: 0.22.1
>
> Attachments: MAPREDUCE-4318.patch
>
>
> TestRecoveryManager should not use deprecated config keys, and should use constants for the keys where possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira