[GitHub] conglei edited a comment on issue #5692: [SIP-6] [Embeddable Charts] Migrate visualization-specific code to js plugin

[GitBox <gi...@apache.org>]

conglei edited a comment on issue #5692: [SIP-6] [Embeddable Charts] Migrate visualization-specific code to js plugin
URL: https://github.com/apache/incubator-superset/issues/5692#issuecomment-417753890
 
 
   # Refractor of `get_data()`
   
   ## goals 
   
   Decoupling all `get_data()` functions in `viz.py` with visualization types. To do this, we should:
   
   - move chart specific logic to visualization frontend code base.
   - create a new field in `form_data` to specify some standard data processing method. (This is ONLY for some computational heavy process AND cannot be done by `query_object`).
   - move away the config parameters (e.g., `mapbox_token`).
   
   Status of moving `get_data()` logic to frontend (or decouple the logic with visualization type).
   
   | PR                                                     | Visualization | Status |
   |--------------------------------------------------------|---------------|--------|
   | https://github.com/apache/incubator-superset/pull/5753 | Piechart |    merged    |
   |                                                        |               |        |
   |                                                        |               |        |

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org