You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/24 09:12:17 UTC
[GitHub] [thrift] emmenlau opened a new pull request #2115: Rework the consistency between NodeJS and Javascript
emmenlau opened a new pull request #2115:
URL: https://github.com/apache/thrift/pull/2115
The Thrift implementations for NodeJS and Javascript seem to have come from the same origins, and the code shares a strong resemblance. However it seems the implementations have deviated over time. The differences I could identify in this PR are mostly harmless minor syntax differences. I've also identified a number of issues where exports have been inconsistent. So the overall user experience and the maintainability should be significantly improved by this PR.
But in any case, it may be good if someone reviews this carefully with a second pair of eyes.
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] dcelasun commented on pull request #2115: Rework the consistency between NodeJS and Javascript
Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2115:
URL: https://github.com/apache/thrift/pull/2115#issuecomment-619019610
LGTM and all tests are green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org