[GitHub] [solr] gerlowskija commented on pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

[GitBox <gi...@apache.org>]

gerlowskija commented on PR #1126:
URL: https://github.com/apache/solr/pull/1126#issuecomment-1303884400

   Recent changes (`@Schema` documentation, failure-case unit tests, API class renaming) all look great.
   
   To summarize where we are, I think there's two remaining items to clear up before this can be merged:
   
   1. A decision on whether we should hold strict backcompat for the v1 LISTSNAPSHOT response format, or go with the (clearly preferable) syntax the v2 API has currently.  I opened a dev@ thread about that, which slows this PR down a bit, but it's better to get consensus on this rather than risk someone complaining later.  If there's no objections by mid-next week I say we go forward with the improved syntax.
   2. Handling of the async param.  I think I offered to help with this in JIRA; so I'll take a crack at it if you haven't already started in on it @Jdurham2843 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org