You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Israel Ekpo <is...@aicer.org> on 2013/04/13 15:17:37 UTC

Review Request: FLUME-1886 - Add a JMS enum type to SourceType

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10446/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Updated SourceType and SourceConfiguration to support this improvement


This addresses bug FLUME-1886.
    https://issues.apache.org/jira/browse/FLUME-1886


Diffs
-----

  flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java 7029615 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java a1bcd58 

Diff: https://reviews.apache.org/r/10446/diff/


Testing
-------


Thanks,

Israel Ekpo

Re: Review Request: FLUME-1886 - Add a JMS enum type to SourceType

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10446/#review20257
-----------------------------------------------------------

Ship it!


Ship It!

- Hari Shreedharan


On April 24, 2013, 11:46 a.m., Israel Ekpo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10446/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 11:46 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Updated SourceType and SourceConfiguration to support this improvement
> 
> 
> This addresses bug FLUME-1886.
>     https://issues.apache.org/jira/browse/FLUME-1886
> 
> 
> Diffs
> -----
> 
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java 7029615 
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java a1bcd58 
>   flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java ffbe177 
>   flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSSourceCreation.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10446/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests to simulate how this source is loaded.
> 
> Also modified tests to cover other sources as well.
> 
> 
> Thanks,
> 
> Israel Ekpo
> 
>

Re: Review Request: FLUME-1886 - Add a JMS enum type to SourceType

Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10446/
-----------------------------------------------------------

(Updated April 24, 2013, 11:46 a.m.)


Review request for Flume.


Description
-------

Updated SourceType and SourceConfiguration to support this improvement


This addresses bug FLUME-1886.
    https://issues.apache.org/jira/browse/FLUME-1886


Diffs (updated)
-----

  flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java 7029615 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java a1bcd58 
  flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java ffbe177 
  flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSSourceCreation.java PRE-CREATION 

Diff: https://reviews.apache.org/r/10446/diff/


Testing
-------

Added unit tests to simulate how this source is loaded.

Also modified tests to cover other sources as well.


Thanks,

Israel Ekpo

Re: Review Request: FLUME-1886 - Add a JMS enum type to SourceType

Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10446/
-----------------------------------------------------------

(Updated April 24, 2013, 11:46 a.m.)


Review request for Flume.


Description
-------

Updated SourceType and SourceConfiguration to support this improvement


This addresses bug FLUME-1886.
    https://issues.apache.org/jira/browse/FLUME-1886


Diffs
-----

  flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java 7029615 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java a1bcd58 

Diff: https://reviews.apache.org/r/10446/diff/


Testing (updated)
-------

Added unit tests to simulate how this source is loaded.

Also modified tests to cover other sources as well.


Thanks,

Israel Ekpo