You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/08/24 16:43:06 UTC
[GitHub] [trafficserver] bneradt opened a new pull request #8274: Use better done file locations for some AuTests
bneradt opened a new pull request #8274:
URL: https://github.com/apache/trafficserver/pull/8274
Some of the AuTests used a done file for AuTest process Ready
conditions. These files got left around in the test directory. This
change puts these done files in the sandbox instead.
Fixes #5546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #8274: Use better done file locations for some AuTests
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #8274:
URL: https://github.com/apache/trafficserver/pull/8274#discussion_r695094345
##########
File path: tests/gold_tests/continuations/double_h2.test.py
##########
@@ -109,9 +109,13 @@
def make_done_stat_ready(tsenv):
def done_stat_ready(process, hasRunFor, **kw):
- retval = subprocess.run("traffic_ctl metric get continuations_verify.test.done > done 2> /dev/null", shell=True, env=tsenv)
+ done_file = os.path.join(process.RunDirectory, "continuations_verify.done")
+ retval = subprocess.run(
Review comment:
Yeah, that's a good idea. Let me try that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #8274: Use better done file locations for some AuTests
Posted by GitBox <gi...@apache.org>.
bneradt merged pull request #8274:
URL: https://github.com/apache/trafficserver/pull/8274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on a change in pull request #8274: Use better done file locations for some AuTests
Posted by GitBox <gi...@apache.org>.
randall commented on a change in pull request #8274:
URL: https://github.com/apache/trafficserver/pull/8274#discussion_r695070554
##########
File path: tests/gold_tests/continuations/double_h2.test.py
##########
@@ -109,9 +109,13 @@
def make_done_stat_ready(tsenv):
def done_stat_ready(process, hasRunFor, **kw):
- retval = subprocess.run("traffic_ctl metric get continuations_verify.test.done > done 2> /dev/null", shell=True, env=tsenv)
+ done_file = os.path.join(process.RunDirectory, "continuations_verify.done")
+ retval = subprocess.run(
Review comment:
Or how about getting rid of the redirection/grep and doing it in pure python?
eg
```
retval = subprocess.run("traffic_ctl metric get continuations_verify.test.done", shell=True, capture_output=True, text=True, env=tsenv)
return retval.returncode == 0 and '1' in retval.stdout
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org