You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by de...@apache.org on 2007/06/16 23:24:16 UTC

svn commit: r547986 - in /webservices/axis2/trunk/java/modules: adb/src/org/apache/axis2/rpc/receivers/RPCMessageReceiver.java kernel/src/org/apache/axis2/description/OutInAxisOperation.java

Author: deepal
Date: Sat Jun 16 14:24:15 2007
New Revision: 547986

URL: http://svn.apache.org/viewvc?view=rev&rev=547986
Log:
fixing the issue.
 -In the client side if you are giving a reply to epr then please either have end point ready for the epr

Modified:
    webservices/axis2/trunk/java/modules/adb/src/org/apache/axis2/rpc/receivers/RPCMessageReceiver.java
    webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/OutInAxisOperation.java

Modified: webservices/axis2/trunk/java/modules/adb/src/org/apache/axis2/rpc/receivers/RPCMessageReceiver.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/adb/src/org/apache/axis2/rpc/receivers/RPCMessageReceiver.java?view=diff&rev=547986&r1=547985&r2=547986
==============================================================================
--- webservices/axis2/trunk/java/modules/adb/src/org/apache/axis2/rpc/receivers/RPCMessageReceiver.java (original)
+++ webservices/axis2/trunk/java/modules/adb/src/org/apache/axis2/rpc/receivers/RPCMessageReceiver.java Sat Jun 16 14:24:15 2007
@@ -164,7 +164,7 @@
             String msg = "Exception occurred while trying to invoke service method " +
                     method.getName();
             log.error(msg, e);
-            throw new AxisFault(msg, e);
+            throw AxisFault.makeFault(e);
         }
     }
 }

Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/OutInAxisOperation.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/OutInAxisOperation.java?view=diff&rev=547986&r1=547985&r2=547986
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/OutInAxisOperation.java (original)
+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/OutInAxisOperation.java Sat Jun 16 14:24:15 2007
@@ -189,6 +189,10 @@
                 useAsync = useAsyncOption.booleanValue();
             }
         }
+        EndpointReference replyTo = mc.getReplyTo();
+        if(replyTo!=null&&!replyTo.hasAnonymousAddress()){
+            useAsync = true;
+        }
 
         if (useAsync || options.isUseSeparateListener()) {
             sendAsync(useAsync, mc);
@@ -248,17 +252,18 @@
             useCustomListener = Boolean.TRUE;
         }
         if (useCustomListener == null || !useCustomListener.booleanValue()) {
-
-            EndpointReference replyToFromTransport =
-                    mc.getConfigurationContext().getListenerManager().
-                            getEPRforService(sc.getAxisService().getName(),
-                                    axisOp.getName().getLocalPart(), mc
-                                    .getTransportIn().getName());
-
-            if (mc.getReplyTo() == null) {
-                mc.setReplyTo(replyToFromTransport);
-            } else {
-                mc.getReplyTo().setAddress(replyToFromTransport.getAddress());
+            if(mc.getReplyTo()==null){
+                EndpointReference replyToFromTransport =
+                        mc.getConfigurationContext().getListenerManager().
+                                getEPRforService(sc.getAxisService().getName(),
+                                        axisOp.getName().getLocalPart(), mc
+                                        .getTransportIn().getName());
+
+                if (mc.getReplyTo() == null) {
+                    mc.setReplyTo(replyToFromTransport);
+                } else {
+                    mc.getReplyTo().setAddress(replyToFromTransport.getAddress());
+                }
             }
         }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org


Re: svn commit: r547986 - in /webservices/axis2/trunk/java/modules: adb/src/org/apache/axis2/rpc/receivers/RPCMessageReceiver.java kernel/src/org/apache/axis2/description/OutInAxisOperation.java

Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
deepal@apache.org wrote:
> +            if(mc.getReplyTo()==null){
> +                EndpointReference replyToFromTransport =
> +                        mc.getConfigurationContext().getListenerManager().
> +                                getEPRforService(sc.getAxisService().getName(),
> +                                        axisOp.getName().getLocalPart(), mc
> +                                        .getTransportIn().getName());
> +
> +                if (mc.getReplyTo() == null) {
> +                    mc.setReplyTo(replyToFromTransport);
> +                } else {
> +                    mc.getReplyTo().setAddress(replyToFromTransport.getAddress());
> +                }
>              }

The above code looks buggy; there's a nested mc.getReplyTo () == null test.

Sanjiva.
-- 
Sanjiva Weerawarana, Ph.D.
Founder & Director; Lanka Software Foundation; http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Director; Open Source Initiative; http://www.opensource.org/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org


Re: svn commit: r547986 - in /webservices/axis2/trunk/java/modules: adb/src/org/apache/axis2/rpc/receivers/RPCMessageReceiver.java kernel/src/org/apache/axis2/description/OutInAxisOperation.java

Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
deepal@apache.org wrote:
> +            if(mc.getReplyTo()==null){
> +                EndpointReference replyToFromTransport =
> +                        mc.getConfigurationContext().getListenerManager().
> +                                getEPRforService(sc.getAxisService().getName(),
> +                                        axisOp.getName().getLocalPart(), mc
> +                                        .getTransportIn().getName());
> +
> +                if (mc.getReplyTo() == null) {
> +                    mc.setReplyTo(replyToFromTransport);
> +                } else {
> +                    mc.getReplyTo().setAddress(replyToFromTransport.getAddress());
> +                }
>              }

The above code looks buggy; there's a nested mc.getReplyTo () == null test.

Sanjiva.
-- 
Sanjiva Weerawarana, Ph.D.
Founder & Director; Lanka Software Foundation; http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Director; Open Source Initiative; http://www.opensource.org/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org