You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Johan Corveleyn <jc...@gmail.com> on 2012/09/03 10:30:57 UTC

Re: Inline added-item properties in REPORT response

On Fri, Aug 31, 2012 at 2:03 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On Thu, Aug 30, 2012 at 10:43 PM, C. Michael Pilato <cm...@collab.net> wrote:
>> On 08/30/2012 10:45 AM, Ivan Zhakov wrote:
>>> On Thu, Aug 30, 2012 at 4:56 PM, C. Michael Pilato <cm...@collab.net> wrote:
>>>> Theoretically, though, it seems reasonable that my approach would have the
>>>> distinct non-feature of potentially having the client caching the properties
>>>> for an entire tree in memory, just waiting for a place to put them.
>>>
>>> It should not happen in current ra_serf editor implementation: parsing
>>> REPORT will be paused when active_fetchs + active_propfinds greater
>>> than 1000. See REQUEST_COUNT_TO_PAUSE/REQUEST_COUNT_TO_RESUME
>>> constants in libsvn_ra_serf/update.c
>>
>> Excellent!  Thanks for pointing that out, Ivan.
>>
> I've just tested your change and I want to say that it's really cool:
> switching between serf trunk and 0.3.x branch is just 5 (five!)
> requests and 27k of traffic. I think it's my most wanted change in svn
> 1.8.x :)

Could the mod_dav_svn part of this be backported to 1.7? Would be nice
for those that are close to upgrading their server to 1.7, so that
when 1.8 comes around they get this benefit immediately for their 1.8
clients, without having to upgrade their server again.

-- 
Johan

Re: Inline added-item properties in REPORT response

Posted by Branko Čibej <br...@wandisco.com>.
On 03.09.2012 10:30, Johan Corveleyn wrote:
> On Fri, Aug 31, 2012 at 2:03 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>> On Thu, Aug 30, 2012 at 10:43 PM, C. Michael Pilato <cm...@collab.net> wrote:
>>> On 08/30/2012 10:45 AM, Ivan Zhakov wrote:
>>>> On Thu, Aug 30, 2012 at 4:56 PM, C. Michael Pilato <cm...@collab.net> wrote:
>>>>> Theoretically, though, it seems reasonable that my approach would have the
>>>>> distinct non-feature of potentially having the client caching the properties
>>>>> for an entire tree in memory, just waiting for a place to put them.
>>>> It should not happen in current ra_serf editor implementation: parsing
>>>> REPORT will be paused when active_fetchs + active_propfinds greater
>>>> than 1000. See REQUEST_COUNT_TO_PAUSE/REQUEST_COUNT_TO_RESUME
>>>> constants in libsvn_ra_serf/update.c
>>> Excellent!  Thanks for pointing that out, Ivan.
>>>
>> I've just tested your change and I want to say that it's really cool:
>> switching between serf trunk and 0.3.x branch is just 5 (five!)
>> requests and 27k of traffic. I think it's my most wanted change in svn
>> 1.8.x :)
> Could the mod_dav_svn part of this be backported to 1.7? Would be nice
> for those that are close to upgrading their server to 1.7, so that
> when 1.8 comes around they get this benefit immediately for their 1.8
> clients, without having to upgrade their server again.

This is not a bug fix, so no, I don't think this would be a candidate
for 1.7 backport.

-- Brane

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download